MG-2477 - Replace Things with Clients #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
requested changes
Nov 5, 2024
| // for magistrala services. | ||
| service ThingsService { | ||
| service ClientsService { |
There was a problem hiding this comment.
Can we change this file name to clients.proto ?
ws/api/endpoint_test.go
Outdated
| @@ -13,12 +13,12 @@ import ( | |||
| "testing" | |||
|
|
|||
| chmocks "github.com/absmach/magistrala/channels/mocks" | |||
| thmocks "github.com/absmach/magistrala/clients/mocks" | |||
There was a problem hiding this comment.
Instead of thmocks can we have something like cmocks or climocks
internal/grpc/token/v1/token.pb.go
Outdated
| @@ -3,8 +3,8 @@ | |||
|
|
|||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.35.1 | |||
| // protoc v5.28.2 | |||
| // protoc-gen-go v1.34.2 | |||
There was a problem hiding this comment.
Please use latest version of protoc-gen-go & protoc
or
protoc-gen-go v1.35.1
protoc v5.28.2
http/README.md
Outdated
| | MG_CLIENTS_AUTH_GRPC_URL | Things service Auth gRPC URL | <localhost:7000> | | ||
| | MG_CLIENTS_AUTH_GRPC_TIMEOUT | Things service Auth gRPC request timeout in seconds | 1s | | ||
| | MG_CLIENTS_AUTH_GRPC_CLIENT_CERT | Path to the PEM encoded things service Auth gRPC client certificate file | "" | | ||
| | MG_CLIENTS_AUTH_GRPC_CLIENT_KEY | Path to the PEM encoded things service Auth gRPC client key file | "" | | ||
| | MG_THINGS_AUTH_GRPC_SERVER_CERTS | Path to the PEM encoded things server Auth gRPC server trusted CA certificate file | "" | | ||
| | MG_MESSAGE_BROKER_URL | Message broker instance URL | <nats://localhost:4222> | |
There was a problem hiding this comment.
Suggested change
| | MG_MESSAGE_BROKER_URL | Message broker instance URL | <nats://localhost:4222> | | |
| | MG_CLIENTS_AUTH_GRPC_URL | Clients service Auth gRPC URL | <localhost:7000> | | |
| | MG_CLIENTS_AUTH_GRPC_TIMEOUT | Clients service Auth gRPC request timeout in seconds | 1s | | |
| | MG_CLIENTS_AUTH_GRPC_CLIENT_CERT | Path to the PEM encoded clients service Auth gRPC client certificate file | "" | | |
| | MG_CLIENTS_AUTH_GRPC_CLIENT_KEY | Path to the PEM encoded clients service Auth gRPC client key file | "" | | |
| | MG_CLIENTS_AUTH_GRPC_SERVER_CERTS | Path to the PEM encoded clients server Auth gRPC server trusted CA certificate file | "" | |
Then please change in line https://github.com/dborovcanin/magistrala/blob/7a2274d48234c17ba835427efaf49de4dcdddc75/http/README.md#L31-L32
| MG_CLIENTS_AUTH_GRPC_URL=localhost:7000 \ | ||
| MG_CLIENTS_AUTH_GRPC_TIMEOUT=1s \ | ||
| MG_CLIENTS_AUTH_GRPC_CLIENT_CERT="" \ | ||
| MG_CLIENTS_AUTH_GRPC_CLIENT_KEY="" \ | ||
| MG_THINGS_AUTH_GRPC_SERVER_CERTS="" \ | ||
| MG_MESSAGE_BROKER_URL=nats://localhost:4222 \ |
There was a problem hiding this comment.
Suggested change
| MG_MESSAGE_BROKER_URL=nats://localhost:4222 \ | |
| MG_CLIENTS_AUTH_GRPC_SERVER_CERTS="" \ |
| # Things client grpc certificates | ||
| $(file > $(CRT_LOCATION)/$(THINGS_GRPC_CLIENT_CRT_FILE_NAME).conf,$(subst <<SERVICE_NAME>>,$(THINGS_GRPC_CLIENT_CN),$(GRPC_CERT_CONFIG)) ) | ||
| $(file > $(CRT_LOCATION)/$(CLIENTS_GRPC_CLIENT_CRT_FILE_NAME).conf,$(subst <<SERVICE_NAME>>,$(CLIENTS_GRPC_CLIENT_CN),$(GRPC_CERT_CONFIG)) ) |
There was a problem hiding this comment.
Suggested change
| $(file > $(CRT_LOCATION)/$(CLIENTS_GRPC_CLIENT_CRT_FILE_NAME).conf,$(subst <<SERVICE_NAME>>,$(CLIENTS_GRPC_CLIENT_CN),$(GRPC_CERT_CONFIG)) ) | |
| # Clients client grpc certificates |
coap/README.md
Outdated
| | MG_CLIENTS_AUTH_GRPC_URL | Things service Auth gRPC URL | <localhost:7000> | | ||
| | MG_CLIENTS_AUTH_GRPC_TIMEOUT | Things service Auth gRPC request timeout in seconds | 1s | | ||
| | MG_CLIENTS_AUTH_GRPC_CLIENT_CERT | Path to the PEM encoded things service Auth gRPC client certificate file | "" | | ||
| | MG_CLIENTS_AUTH_GRPC_CLIENT_KEY | Path to the PEM encoded things service Auth gRPC client key file | "" | | ||
| | MG_THINGS_AUTH_GRPC_SERVER_CERTS | Path to the PEM encoded things server Auth gRPC server trusted CA certificate file | "" | | ||
| | MG_MESSAGE_BROKER_URL | Message broker instance URL | <nats://localhost:4222> | |
There was a problem hiding this comment.
Suggested change
| | MG_MESSAGE_BROKER_URL | Message broker instance URL | <nats://localhost:4222> | | |
| | MG_CLIENTS_AUTH_GRPC_URL | Clients service Auth gRPC URL | <localhost:7000> | | |
| | MG_CLIENTS_AUTH_GRPC_TIMEOUT | Clients service Auth gRPC request timeout in seconds | 1s | | |
| | MG_CLIENTS_AUTH_GRPC_CLIENT_CERT | Path to the PEM encoded clients service Auth gRPC client certificate file | "" | | |
| | MG_CLIENTS_AUTH_GRPC_CLIENT_KEY | Path to the PEM encoded clients service Auth gRPC client key file | "" | | |
| | MG_CLIENTS_AUTH_GRPC_SERVER_CERTS | Path to the PEM encoded clients server Auth gRPC server trusted CA certificate file | "" | |
| MG_CLIENTS_AUTH_GRPC_URL=localhost:7000 \ | ||
| MG_CLIENTS_AUTH_GRPC_TIMEOUT=1s \ | ||
| MG_CLIENTS_AUTH_GRPC_CLIENT_CERT="" \ | ||
| MG_CLIENTS_AUTH_GRPC_CLIENT_KEY="" \ | ||
| MG_THINGS_AUTH_GRPC_SERVER_CERTS="" \ | ||
| MG_MESSAGE_BROKER_URL=nats://localhost:4222 \ |
There was a problem hiding this comment.
Suggested change
| MG_MESSAGE_BROKER_URL=nats://localhost:4222 \ | |
| MG_CLIENTS_AUTH_GRPC_SERVER_CERTS="" \ |
| @@ -72,7 +72,7 @@ $GOBIN/magistrala-coap | |||
|
|
|||
| Setting `MG_COAP_ADAPTER_SERVER_CERT` and `MG_COAP_ADAPTER_SERVER_KEY` will enable TLS against the service. The service expects a file in PEM format for both the certificate and the key. Setting `MG_COAP_ADAPTER_HTTP_SERVER_CERT` and `MG_COAP_ADAPTER_HTTP_SERVER_KEY` will enable TLS against the service. The service expects a file in PEM format for both the certificate and the key. | |||
|
|
|||
| Setting `MG_THINGS_AUTH_GRPC_CLIENT_CERT` and `MG_THINGS_AUTH_GRPC_CLIENT_KEY` will enable TLS against the things service. The service expects a file in PEM format for both the certificate and the key. Setting `MG_THINGS_AUTH_GRPC_SERVER_CERTS` will enable TLS against the things service trusting only those CAs that are provided. The service expects a file in PEM format of trusted CAs. | |||
| Setting `MG_CLIENTS_AUTH_GRPC_CLIENT_CERT` and `MG_CLIENTS_AUTH_GRPC_CLIENT_KEY` will enable TLS against the things service. The service expects a file in PEM format for both the certificate and the key. Setting `MG_THINGS_AUTH_GRPC_SERVER_CERTS` will enable TLS against the things service trusting only those CAs that are provided. The service expects a file in PEM format of trusted CAs. | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| Setting `MG_CLIENTS_AUTH_GRPC_CLIENT_CERT` and `MG_CLIENTS_AUTH_GRPC_CLIENT_KEY` will enable TLS against the clients service. The service expects a file in PEM format for both the certificate and the key. Setting `MG_CLIENTS_AUTH_GRPC_SERVER_CERTS` will enable TLS against the clients service trusting only those CAs that are provided. The service expects a file in PEM format of trusted CAs. |
cmd/ws/main.go
Outdated
| @@ -15,7 +15,7 @@ import ( | |||
| chclient "github.com/absmach/callhome/pkg/client" | |||
| "github.com/absmach/magistrala" | |||
| grpcChannelsV1 "github.com/absmach/magistrala/internal/grpc/channels/v1" | |||
| grpcThingsV1 "github.com/absmach/magistrala/internal/grpc/things/v1" | |||
| grpcClientsV1 "github.com/absmach/magistrala/internal/grpc/things/v1" | |||
There was a problem hiding this comment.
Please change
envPrefixClients = "MG_CLIENTS_AUTH_GRPC_"
to
envPrefixClients = "MG_CLIENTS_AUTH_GRPC_"
at here
https://github.com/dborovcanin/magistrala/blob/7a2274d48234c17ba835427efaf49de4dcdddc75/cmd/ws/main.go#L43
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
reviewed
Nov 7, 2024
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| MG_DOCKER_IMAGE_NAME_PREFIX ?= magistrala | |||
| BUILD_DIR ?= build | |||
| SERVICES = auth users things groups channels domains http coap ws postgres-writer postgres-reader timescale-writer \ | |||
| SERVICES = auth users clients groups channels domains http coap ws postgres-writer postgres-reader timescale-writer \ | |||
| timescale-reader cli bootstrap mqtt provision certs invitations journal | |||
| TEST_API_SERVICES = journal auth bootstrap certs http invitations notifiers provision readers things users | |||
| TEST_API = $(addprefix test_api_,$(TEST_API_SERVICES)) | |||
There was a problem hiding this comment.
Suggested change
| TEST_API = $(addprefix test_api_,$(TEST_API_SERVICES)) | |
| TEST_API_SERVICES = journal auth bootstrap certs http invitations notifiers provision readers clients users |
dborovcanin
force-pushed
the
things-client
branch
3 times, most recently
from
39f6101 to
8cf529f
Compare
Signed-off-by: Dusan Borovcanin <[email protected]>
dborovcanin
force-pushed
the
things-client
branch
from
8cf529f to
4ce7e85
Compare
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
dborovcanin
force-pushed
the
things-client
branch
from
fd96bf6 to
856a7f1
Compare
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Please change fro thingID to clientID at here
https://github.com/absmach/magistrala/blob/4ce7e8580f8229a3850873e7c348407b7ee95074/clients/api/http/decode.go#L18
arvindh123
requested changes
Nov 8, 2024
| "github.com/absmach/magistrala/internal/api" | ||
| "github.com/absmach/magistrala/pkg/apiutil" | ||
| "github.com/absmach/magistrala/pkg/errors" | ||
| "github.com/absmach/magistrala/things" | ||
| "github.com/go-chi/chi/v5" | ||
| ) |
There was a problem hiding this comment.
Please change thingID to clientID in all the places in this file
Signed-off-by: Dusan Borovcanin <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
requested changes
Nov 10, 2024
| @@ -16,18 +16,18 @@ import ( | |||
| // MGKey is key of corresponding Magistrala Thing. | |||
| // MGChannels is a list of Magistrala Channels corresponding Magistrala Thing connects to. | |||
| type Config struct { | |||
There was a problem hiding this comment.
Suggested change
| type Config struct { | |
| // MGKey is key of corresponding Magistrala client. | |
| // MGChannels is a list of Magistrala Channels corresponding Magistrala Client connects to. |
bootstrap/reader.go
Outdated
| @@ -16,7 +16,7 @@ import ( | |||
| // This is used as a response from ConfigReader and can easily be | |||
| // replace with any other response format. | |||
| type bootstrapRes struct { | |||
| ThingID string `json:"thing_id"` | |||
| ThingID string `json:"client_id"` | |||
| ThingKey string `json:"thing_key"` | |||
There was a problem hiding this comment.
Please change here to client_key
bootstrap/api/responses.go
Outdated
| @@ -67,7 +67,7 @@ type channelRes struct { | |||
| } | |||
|
|
|||
| type viewRes struct { | |||
| ThingID string `json:"thing_id,omitempty"` | |||
| ThingID string `json:"client_id,omitempty"` | |||
| ThingKey string `json:"thing_key,omitempty"` | |||
There was a problem hiding this comment.
please chagne here to client_key
| @@ -33,7 +33,7 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| fullMatch = []string{"state", "external_id", "thing_id", "thing_key"} | |||
| fullMatch = []string{"state", "external_id", "client_id", "thing_key"} | |||
There was a problem hiding this comment.
please change here to thing_key
Signed-off-by: Dusan Borovcanin <[email protected]>
dborovcanin
force-pushed
the
things-client
branch
from
2eeb708 to
ca5bca1
Compare
arvindh123
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Bootstrap events name contains thing at here
https://github.com/dborovcanin/magistrala/blob/2eeb708a1cb9df1d0157531c93cda087c9985ed3/bootstrap/events/producer/events.go#L20-L25
I think this should be change to client , in order consume or emit the client event
pkg/apiutil/token.go
Outdated
| @@ -29,9 +29,9 @@ func ExtractBearerToken(r *http.Request) string { | |||
| func ExtractThingKey(r *http.Request) string { | |||
There was a problem hiding this comment.
I think we can change this function name to ExtractClientKey
| @@ -21,7 +21,7 @@ const ( | |||
| channelUpdate = channelPrefix + "update" | |||
There was a problem hiding this comment.
In this file i think we should change the event name to client
| @@ -44,34 +44,34 @@ func (es *eventHandler) Handle(ctx context.Context, event events.Event) error { | |||
|
|
|||
| switch msg["operation"] { | |||
| case thingRemove: | |||
There was a problem hiding this comment.
The value of thingRemove is thing.remove , this should be changed to client.remove
| @@ -44,34 +44,34 @@ func (es *eventHandler) Handle(ctx context.Context, event events.Event) error { | |||
|
|
|||
| switch msg["operation"] { | |||
| case thingRemove: | |||
| rte := decodeRemoveThing(msg) | |||
| rte := decodeRemoveClient(msg) | |||
| err = es.svc.RemoveConfigHandler(ctx, rte.id) | |||
| case thingConnect: | |||
There was a problem hiding this comment.
The value of thingConnect is thing.connect , this should be changed to client.connect
| return svcerr.ErrMalformedEntity | ||
| } | ||
| if err := es.svc.ConnectThingHandler(ctx, cte.channelID, thingID); err != nil { | ||
| if err := es.svc.ConnectClientHandler(ctx, cte.channelID, clientID); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| case thingDisconnect: |
There was a problem hiding this comment.
same kind of suggestion here
| return svcerr.ErrMalformedEntity | ||
| } | ||
| for _, thingID := range dte.thingIDs { | ||
| for _, thingID := range dte.clientIDs { |
There was a problem hiding this comment.
since this line is changed to clientID because other we have dte.clientIDs
arvindh123
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Bootstrap events name contains thing at here
https://github.com/dborovcanin/magistrala/blob/2eeb708a1cb9df1d0157531c93cda087c9985ed3/bootstrap/events/producer/events.go#L20-L25
I think this should be change to client , in order consume or emit the client event
arvindh123
requested changes
Nov 10, 2024
There was a problem hiding this comment.
at here https://github.com/dborovcanin/magistrala/blob/2eeb708a1cb9df1d0157531c93cda087c9985ed3/bootstrap/events/producer/streams.go#L75-L76
something like this we should have ,
Since we chaning to ClientKey, we use the same term for certificate key
- func (es eventStore) UpdateCert(ctx context.Context, session mgauthn.Session, thingKey, clientCert, clientKey, caCert string) (bootstrap.Config, error)
+ func (es eventStore) UpdateCert(ctx context.Context, session mgauthn.Session, clientKey, clientCert, clientCertKey, caCert string) (bootstrap.Config, error) {
arvindh123
requested changes
Nov 10, 2024
There was a problem hiding this comment.
At here we should change to mainflux_client
https://github.com/dborovcanin/magistrala/blob/2eeb708a1cb9df1d0157531c93cda087c9985ed3/bootstrap/postgres/init.go#L16
Because in insert query we have mainflux_client
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
requested changes
Nov 10, 2024
There was a problem hiding this comment.
Please change to PclientID} at this endpoint https://github.com/dborovcanin/magistrala/blob/8bd008be6298d2b634b68161ebc78d3822e446f2/users/api/users.go#L203
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
pushed a commit
to arvindh123/supermq
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 12, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Dusan Borovcanin <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 18, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 25, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 26, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 26, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Nov 26, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
felixgateru
pushed a commit
to felixgateru/supermq
that referenced
this pull request
Nov 27, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
dborovcanin
pushed a commit
to felixgateru/supermq
that referenced
this pull request
Nov 27, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Nov 27, 2024
- Set/Unset parent Group for Things and Channels (#2486) - Move groups out of pkg (#2493) - Separate Things authn and Channels authz (#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Nov 27, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
felixgateru
pushed a commit
to felixgateru/supermq
that referenced
this pull request
Nov 27, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
arvindh123
added a commit
to arvindh123/supermq
that referenced
this pull request
Nov 29, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]> MG-2457 - Update domains tests (absmach#2504) Signed-off-by: Felix Gateru <[email protected]> NOISSUE - Get group role actions from Spicedb schema & list groups by user, clients, channels (absmach#2506) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update groups tests (absmach#2509) Signed-off-by: Arvindh <[email protected]> Signed-off-by: Felix Gateru <[email protected]> Co-authored-by: Arvindh <[email protected]> NOISSUE - Update Proto file version, fix protolint (absmach#2552) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update channels tests (absmach#2511) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update clients tests (absmach#2543) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update adapter tests (absmach#2529) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update readers tests (absmach#2544) Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]> Co-authored-by: Arvindh <[email protected]>
felixgateru
pushed a commit
to felixgateru/supermq
that referenced
this pull request
Nov 29, 2024
- Set/Unset parent Group for Things and Channels (absmach#2486) - Move groups out of pkg (absmach#2493) - Separate Things authn and Channels authz (absmach#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (absmach#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (absmach#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (absmach#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Dec 2, 2024
- Set/Unset parent Group for Things and Channels (#2486) - Move groups out of pkg (#2493) - Separate Things authn and Channels authz (#2496) Signed-off-by: Arvindh <[email protected]> NOISSUE - Add Publish/Subscribe to channels (#2497) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update auth tests (#2503) Signed-off-by: Felix Gateru <[email protected]> MG-2477 - Replace Things with Clients (#2508) Signed-off-by: Dusan Borovcanin <[email protected]> NOISSUE - Rename Things to Clients Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]> MG-2457 - Update domains tests (#2504) Signed-off-by: Felix Gateru <[email protected]> NOISSUE - Get group role actions from Spicedb schema & list groups by user, clients, channels (#2506) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update groups tests (#2509) Signed-off-by: Arvindh <[email protected]> Signed-off-by: Felix Gateru <[email protected]> Co-authored-by: Arvindh <[email protected]> NOISSUE - Update Proto file version, fix protolint (#2552) Signed-off-by: Arvindh <[email protected]> MG-2457 - Update channels tests (#2511) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update clients tests (#2543) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update adapter tests (#2529) Signed-off-by: Felix Gateru <[email protected]> MG-2457 - Update readers tests (#2544) Signed-off-by: Felix Gateru <[email protected]> Signed-off-by: Arvindh <[email protected]> Co-authored-by: Arvindh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a rename of the service.
What does this do?
This pull request renames Things to Clients. We have been using Clients terminology internally for a while, now it's time to reflect that in the API as well.
Which issue(s) does this PR fix/relate to?
Resolves #2477.
Have you included tests for your changes?
No. Tests are broken at the moment.
Did you document any new/modified feature?
Yes, docs are updated.
Notes
N/A