Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps)!: update dependency conventional-changelog-conventionalcommits to v5. This is technically a breaking change for anyone relying on the exact formatting of the changelog, as it ensures that versions are always written with H2 headers. #23

Merged

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented May 27, 2022

BEGIN_COMMIT_OVERRIDE
fix(deps)!: update dependency conventional-changelog-conventionalcommits to v5. This is technically a breaking change for anyone relying on the exact formatting of the changelog, as it ensures that versions are always written with H2 headers.
END_COMMIT_OVERRIDE

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
conventional-changelog-conventionalcommits (source) 4.6.3 -> 5.0.0 age adoption passing confidence

Release Notes

conventional-changelog/conventional-changelog

v5.0.0: conventional-changelog-conventionalcommits: v5.0.0

Compare Source

⚠ BREAKING CHANGES
  • always use H2 heading for versions (#​920)
Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #23 (b38e900) into master (c208356) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files          27       27           
  Lines        1194     1194           
=======================================
  Hits         1163     1163           
  Misses         31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renovate renovate bot force-pushed the renovate/conventional-changelog-conventionalcommits-5.x branch from ce7b224 to ba02748 Compare May 28, 2022 07:07
@renovate renovate bot force-pushed the renovate/conventional-changelog-conventionalcommits-5.x branch from ba02748 to 53297c2 Compare August 11, 2022 13:01
@renovate renovate bot force-pushed the renovate/conventional-changelog-conventionalcommits-5.x branch from 53297c2 to b38e900 Compare August 11, 2022 13:55
@Mitiryl
Copy link

Mitiryl commented Jan 17, 2023

Hi all,
what about this commit? Will you merge into master?

@TimothyJones
Copy link
Member

Do you want this? I didn’t merge it because I’m not sure if it’s a breaking change- it changes the format of the changelog, and I’m not sure if I should consider that part of the interface or not.

What do you think?

@TimothyJones
Copy link
Member

Very happy to accept it- my gut is that it’s probably a major bump, so it stalled because I wasn’t sure (and didn’t think anyone would be wanting it). But if someone wants it, let’s make a call and get it in.

@Mitiryl
Copy link

Mitiryl commented Jan 17, 2023

Hi @TimothyJones , thank a lot for the quick answer!
My big problem is that the current version of conventional-changelog-conventionalcommits creates the patch with a heading h3, that is semantically incorrect, infact the created changelog has the title h1, and than directly the latest version in h3, and the subsections (bug fixes, features...) also in h3.
My current workaround is to import in my project the latest version of conventional-changelog-conventionalcommits, and overwrite the preset configuration of commit-and-tag-version

@Mitiryl
Copy link

Mitiryl commented Jan 17, 2023

I'm waiting for this update :) but if you prefer, I can create an issue and collect feedbacks from other users.. let me know!

@TimothyJones TimothyJones changed the title fix(deps): update dependency conventional-changelog-conventionalcommits to v5 fix(deps)!: update dependency conventional-changelog-conventionalcommits to v5. This is technically a breaking change for anyone relying on the exact formatting of the changelog, as it ensures that versions are always written with H2 headers. Jan 17, 2023
@TimothyJones TimothyJones merged commit ffa799a into master Jan 17, 2023
@renovate renovate bot deleted the renovate/conventional-changelog-conventionalcommits-5.x branch January 17, 2023 12:02
@TimothyJones
Copy link
Member

I'm releasing this as 11.0.0 now. Thanks for the prompt to do so!

@Mitiryl
Copy link

Mitiryl commented Jan 17, 2023

Thank you very much! I'm going to use the new version now! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants