Check whether it is an expression before accessing the expression properties #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamvelRaja
changed the title
| var lastArgument = route.expression.arguments[route.expression.arguments.length-1]; | ||
| if (types.FunctionExpression.check(lastArgument)) { | ||
| traverseExpressions(lastArgument.body.body); | ||
| if (route.expression) { |
There was a problem hiding this comment.
Can you also check if the AST type is a CallExpression with if (types.CallExpression.check(route.expression)) { ?
|
Looks good, can you add a test covering this issue? |
SamvelRaja
force-pushed
the
patch_added_expression_truthiness
branch
from
32a5f7d to
d809d02
Compare
SamvelRaja
force-pushed
the
patch_added_expression_truthiness
branch
from
d809d02 to
9700acd
Compare
|
Shall i include the test for normal route structure also? or this is enough? @marcioj |
marcioj
added a commit
that referenced
this pull request
Sep 4, 2015
Check whether it is an expression before accessing the expression properties
This is good to go, we have other tests with more common scenarios. Thank you for your contribution! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to check whether the node is a
expressionbefore getting theexpression propertiesFound while testing the issue #79
Feel free to reject the PR if not needed.