Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add uri prop #14

Open
wants to merge 2 commits into
base: feat/use-context-hooks
Choose a base branch
from
Open

feat: add uri prop #14

wants to merge 2 commits into from

Conversation

ryan-m-walker
Copy link
Collaborator

  • added ability to use either fetcher or uri
  • fixed some formatting issues with the default fetcher

@ryan-m-walker
feat: add uri prop
deab4fd 
* added ability to use either fetcher or uri
* fixed some formatting issues with the default fetcher
@acao
Copy link
Owner

acao commented Apr 23, 2020

ok, so I'm gonna bring this into the monaco PR. I think i'll merge it to the feature branch first.

@acao acao marked this pull request as ready for review April 23, 2020 15:53
@acao
Copy link
Owner

acao commented Apr 23, 2020

oh no, codemirror is ghosting. hmmm... maybe we need to re-create this with monaco and the new service worker schema loader, i like how you approached this though.

@acao acao force-pushed the feat/use-context-hooks branch 5 times, most recently from 87a5570 to 9fd2682 Compare May 11, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-m-walker @acao