This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
CSVReader Ignores specified delimiter #538
Comments
Hi Paul, Thanks a lot for reporting the issue! Indeed, if you could make a PR it would be really great! If you need further help, please ask. By the way, I also live in Grenoble, it is nice to see the framework being used so close from home :-) Cesar |
A small world after all :) It could be nice to meet! |
PaulARoy
added a commit
to PaulARoy/framework
that referenced
this issue
Apr 14, 2017
cesarsouza
added a commit
that referenced
this issue
Apr 14, 2017
Fixing #538: CSVReader Ignores specified delimiter
Added in release 3.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there!
First of all thanks for your awesome library.
I noticed that CSVReader completely ignores the delimiter (when specified on constructor) when we use
ToMatrix()
orToTable()
.This is due to
ReadField()
forcing aGuessDelimiterFromBuffer()
on initialization:https://github.com/accord-net/framework/blob/development/Sources/Accord.IO/Csv/CsvReader.cs#L1090
https://github.com/accord-net/framework/blob/development/Sources/Accord.IO/Csv/CsvReader.cs#L1126
This
GuessDelimiterFromBuffer()
should not happen if delimiter was specified from constructor.We noticed the issue because in french the double parser expects
0,12
(instead of0.12
), but reading the matrix0,12;0,13
separates the entries according to','
instead of specified';'
I can make a PR on this issue if needed.
The text was updated successfully, but these errors were encountered: