Add server rendering example #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update `react-transform-hmr`
|
Any feedback about this PR?, would be great to get some comments from the authors about this implementation, Regards. |
| app.use(webpackHotMiddleware(compiler)); | ||
|
|
||
| app.use((req, res) => { | ||
| const store = reduxReactRouter({ routes })(createStore)(reducer); |
There was a problem hiding this comment.
Maybe use { routes, createHistory: createMemoryHistory } instead of { routes }?
|
Sorry for the late response. If you could update the example to be compliant with the current version, I would be happy to add it into the repo. |
|
Needed some updating, but I added it now. Thanks @stevoland for providing the example and @xcatliu for your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at: #77
Also updates
react-transform-hmrThis also illustrates that issue with putting React elements in the store: #57. You get an error if you try to revert to the initial state.