Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue tracker] make Batch mode visible only with developer permission #9422

Closed
1 task
Tracked by #9418
christinerogers opened this issue Oct 25, 2024 · 3 comments · Fixed by #9434
Closed
1 task
Tracked by #9418

[Issue tracker] make Batch mode visible only with developer permission #9422

christinerogers opened this issue Oct 25, 2024 · 3 comments · Fixed by #9434
Assignees
Labels
Priority: High PR or issue should be prioritised over others for review and testing

Comments

@christinerogers
Copy link
Contributor

christinerogers commented Oct 25, 2024

Top-priority followup from #9339, spun out of #9418

Batch mode be visible to all who can see the module, as it is currently.
It's designed for the dev/DCC team to handle and update issues -- End Users of Loris shouldn't be able to see / use Batch mode.

what to do:

  • Hide the Batch Mode button unless the user has issue_tracker_developer permission

Consider doing #9423 at the same time - correct the button style

If time / nice to have: make sure the batch page doesn't load if the user doesn't have issue_tracker_developer

This solves the requirement for a permission restricting access, clearly defined in the original issue, and it was simply not done yet.
I don't want this to block #9339 but it is still important and should be the next PR after #9339.

@ay-bh please follow up with @racostas to ensure we are addressing this as a priority next PR, thank you very much

@christinerogers christinerogers changed the title permission to access this feature, let's say issue_tracker_batch_mode_edit, as I do not see it required nor useful for all users (can be discussed). [Issue tracker] make Batch mode visible only with edit permission Oct 25, 2024
@christinerogers christinerogers changed the title [Issue tracker] make Batch mode visible only with edit permission [Issue tracker] make Batch mode visible only with developer permission Oct 25, 2024
@christinerogers christinerogers added the Priority: High PR or issue should be prioritised over others for review and testing label Oct 25, 2024
@regisoc
Copy link
Contributor

regisoc commented Oct 25, 2024

Thanks for this @christinerogers ! As it is a new feature that we will experiment on, maybe starting with a new permission for beta testing might be more suited. What do you think @racostas @christinerogers @ay-bh ?

@christinerogers
Copy link
Contributor Author

christinerogers commented Oct 26, 2024

I think the minimum necessary here for Nov 1 is that it be governed by an existing permission, and I think the one I specified suffices for now.
This means Ayush only to add 1-2 lines of code (if condition on the button) instead of a schema change, patch etc.

@regisoc -- in case Ayush has more time, could you elaborate on which group of users you think aren't included/excluded with the 'developer' permission? (It's really a DCC permission, coordinators get it too)

@christinerogers
Copy link
Contributor Author

christinerogers commented Oct 28, 2024

@ay-bh tips for getting started:
Look at how buttons are disabled/hidden in other modules depending on a user permission -- Here's an example

Consider doing at the same time #9423

driusan pushed a commit that referenced this issue Nov 7, 2024
…t permission control (#9434)

- Replaced the view toggle button with a tabbed interface using `Tabs`
component
- Added permission check to show Batch Edit tab only for users with
`issue_tracker_developer` permission
- Implemented data refresh when switching back to Browse Issues tab


#### Link(s) to related issue(s)
* Resolves #9422, #9423 
* Part of #9418
ZhichGaming pushed a commit to ZhichGaming/Loris that referenced this issue Nov 25, 2024
…t permission control (aces#9434)

- Replaced the view toggle button with a tabbed interface using `Tabs`
component
- Added permission check to show Batch Edit tab only for users with
`issue_tracker_developer` permission
- Implemented data refresh when switching back to Browse Issues tab


#### Link(s) to related issue(s)
* Resolves aces#9422, aces#9423 
* Part of aces#9418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High PR or issue should be prioritised over others for review and testing
Projects
None yet
3 participants