Replace flag test_name with foreign key to test_names #9338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
FlagTestID
branch
16 times, most recently
from
74c652c to
a150ada
Compare
GeorgeMurad
approved these changes
Sep 20, 2024
This was referenced Nov 6, 2024
driusan
pushed a commit
that referenced
this pull request
Nov 11, 2024
Fix recreate conflicts script after #9338
driusan
pushed a commit
that referenced
this pull request
Nov 11, 2024
Fix more instances of code requiring flag to have the Test_name table after the change in #9338
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
There is a varchar for every row in the flag table, this normalizes it by replacing it with a foreign key to the test_name tables that is already present and populated. This both makes table scans of the flag table faster and is just better schema design.
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
Fix recreate conflicts script after aces#9338
ZhichGaming
pushed a commit
to ZhichGaming/Loris
that referenced
this pull request
Nov 25, 2024
Fix more instances of code requiring flag to have the Test_name table after the change in aces#9338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a varchar for every row in the flag table, this normalizes it by replacing it with a foreign key to the test_name tables that is already present and populated.
This both makes table scans of the flag table faster and is just better schema design.