Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synaptics refactor #54

Merged
merged 23 commits into from
Dec 27, 2022
Merged

Conversation

1Revenger1
Copy link
Contributor

@1Revenger1 1Revenger1 commented Nov 9, 2022

This PR brings some significant changes to both querying the trackpad at startup and handling packets. The querying makes it clearer what feature bits are being looked for, and to use them in the driver itself (for example setting the mode bytes). This also relies on my VoodooInput PR (acidanthera/VoodooInput#22) for fixing some trackpoint bugs as well.

Bugs this should fix:

Notes:

  • This always puts the trackpad into Extended W mode if the trackpad supports Extended W.
  • I left the old VoodooInput API in there for trackpoints to keep compatibility with other drivers, though it may be worth moving the Elans driver over to the new message/report struct.
  • The VoodooInput changes change the multiplier to be a fraction over 64 to allow multipliers below 1, though I'm not sure how needed this is. I'm open to reverting this change if people don't see a need for this since it's not really an intuitive change. A multiplier value of 128 would effectively be a 2x multiplication with this change.

@1Revenger1 1Revenger1 marked this pull request as ready for review November 17, 2022 19:44
NeoBlizzard-verbose added a commit to NeoBlizzard-verbose/Lenovo-G570-Hackintosh that referenced this pull request Nov 24, 2022
Fixes touchpad buttons and also makes the touchpad smoother (as per my observation, YMMV). Thanks to 1Revenger1 for the kext!
Refer:-  acidanthera/VoodooPS2#54
@Woodie-07
Copy link

This fixes the trackpad on my MSI GP62 6QF running Ventura, thanks!

@vit9696
Copy link
Contributor

vit9696 commented Dec 13, 2022

@1Revenger1, I merged the other commit, but at least static analysis is broken.

@usr-sse2
Copy link
Contributor

Seems that nothing got broken on ProBook 4520s with High Sierra

@vit9696 vit9696 merged commit f76cb96 into acidanthera:master Dec 27, 2022
@1Revenger1 1Revenger1 deleted the synaptics_refactor branch January 16, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

DynamicEWMode problem on Lenovo ThinkPad Laptops
4 participants