-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synaptics refactor #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Fails to analyze, which is likely due to an incorrect VoodooInput version
NeoBlizzard-verbose
added a commit
to NeoBlizzard-verbose/Lenovo-G570-Hackintosh
that referenced
this pull request
Nov 24, 2022
Fixes touchpad buttons and also makes the touchpad smoother (as per my observation, YMMV). Thanks to 1Revenger1 for the kext! Refer:- acidanthera/VoodooPS2#54
This fixes the trackpad on my MSI GP62 6QF running Ventura, thanks! |
@1Revenger1, I merged the other commit, but at least static analysis is broken. |
usr-sse2
approved these changes
Dec 27, 2022
Seems that nothing got broken on ProBook 4520s with High Sierra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some significant changes to both querying the trackpad at startup and handling packets. The querying makes it clearer what feature bits are being looked for, and to use them in the driver itself (for example setting the mode bytes). This also relies on my VoodooInput PR (acidanthera/VoodooInput#22) for fixing some trackpoint bugs as well.
Bugs this should fix:
Notes: