Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

Upgrade to Guzzle 6 #54

Open
cpliakas opened this issue Apr 19, 2014 · 10 comments
Open

Upgrade to Guzzle 6 #54

cpliakas opened this issue Apr 19, 2014 · 10 comments
Labels
enhancement
Milestone
2.0

Comments

@cpliakas
Copy link
Contributor

No description provided.

@cpliakas cpliakas changed the title Upgrade to Guzzle 4 Upgrade to Guzzle 5 Apr 8, 2015
@geerlingguy
Copy link

👍

On install, we currently get warnings like:

Package guzzle/inflection is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/common is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/stream is abandoned, you should avoid using it. Use guzzle/guzzle instead.
Package guzzle/parser is abandoned, you should avoid using it. Use guzzle/guzzle instead.
...

webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue May 7, 2015
@webbj74-acquia
Adds composer.json dependency on guzzlehttp/guzzle for acquia#54
8206255 
This is the same version of Guzzle used in [Drupal 8.0.0-beta10](http://cgit.drupalcode.org/drupal/tree/core/composer.json?id=8.0.0-beta10#n23).

```
$ composer require "guzzlehttp/guzzle:~5.0"
./composer.json has been updated
Loading composer repositories with package information
Initializing PEAR repository http://pear.php.net
Updating dependencies (including require-dev)
  - Installing react/promise (v2.2.0)
    Loading from cache

  - Installing guzzlehttp/streams (3.0.0)
    Loading from cache

  - Installing guzzlehttp/ringphp (1.0.7)
    Loading from cache

  - Installing guzzlehttp/guzzle (5.2.0)
    Loading from cache

Writing lock file
Generating autoload files
```
webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue May 7, 2015
@webbj74-acquia
Adds composer.json dependency on guzzlehttp/guzzle for acquia#54
37188d6 
This is the same version of Guzzle used in [Drupal 8.0.0-beta10](http://cgit.drupalcode.org/drupal/tree/core/composer.json?id=8.0.0-beta10#n23).

    $ composer require "guzzlehttp/guzzle:~5.0"
    ./composer.json has been updated
    Loading composer repositories with package information
    Initializing PEAR repository http://pear.php.net
    Updating dependencies (including require-dev)
      - Installing react/promise (v2.2.0)
        Loading from cache

      - Installing guzzlehttp/streams (3.0.0)
        Loading from cache

      - Installing guzzlehttp/ringphp (1.0.7)
        Loading from cache

      - Installing guzzlehttp/guzzle (5.2.0)
        Loading from cache

    Writing lock file
    Generating autoload files
webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue May 7, 2015
@webbj74-acquia
Modifies composer.json dependency on php to >= 5.4.0 for acquia#54
29329f3 
PHP 5.4 is the minimum requirement for the following:

- guzzle 5.2.0
- ringphp 1.0.7
- streams 3.0.0
- phploc 2.1.1
- promise v2.2.0

    $ find vendor -name composer.json -exec grep -o ".\bphp\b.:.*" {} \; | sort -u
    "php": ">=5.2.3"
    "php": ">=5.3",
    "php": ">=5.3.0"
    "php": ">=5.3.0",
    "php": ">=5.3.2"
    "php": ">=5.3.2",
    "php": ">=5.3.3"
    "php": ">=5.3.3",
    "php": ">=5.4",
    "php": ">=5.4.0"
    "php": ">=5.4.0",

    $ find vendor -name composer.json -exec grep -H ".\bphp\b.:.*5\.4" {} \; | sort -u
    vendor/guzzlehttp/guzzle/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/ringphp/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/streams/composer.json:        "php": ">=5.4.0"
    vendor/phploc/phploc/composer.json:        "php": ">=5.4",
    vendor/react/promise/composer.json:        "php": ">=5.4.0"

This commit also removes the php 5.3 test environment from Travis CI.
webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue May 8, 2015
@webbj74-acquia
Modified Collection and Element classes to accept \GuzzleHttp\Message…
8380406 
…\Response as a constructor arg for acquia#54.

This is a backward-compatible modification to Acquia\Rest\Collection and Acquia\Rest\Element so that the constructor may be used interchangeably with Guzzle 3.x and higher. Since guzzle isn't strictly required for the acquia/acquia-sdk-php-rest sub-package, I've added the old and present versions of Guzzle as composer suggestions, and removed the requirement on Guzzle 3.

The constructor for Acquia\Rest\Collection is no longer strongly typed, but will throw an InvalidArgumentException if an unusual object is passed to it.
webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue May 8, 2015
@webbj74-acquia
WIP: Refactor CloudApiClient to use Guzzle ~5.0 for acquia#54
bfb6830
webbj74 pushed a commit to webbj74/acquia-sdk-php that referenced this issue Jul 23, 2015
@webbj74-acquia
WIP: Refactor CloudApiClient to use Guzzle ~5.0 for acquia#54
3962cdc
@skwashd
Copy link

skwashd commented Oct 21, 2015

Guzzle 6 is out. The AWS PHP SDK and Zendesk API libs both depend on Guzzle 6. Please consider skipping 5 and jumping straight to 6.

Zlender added a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@Zlender
Fixes acquia#54 Switch CloudAPIClient to Guzzle 6
5187c5c
Zlender pushed a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@webbj74-acquia @Zlender
Adds composer.json dependency on guzzlehttp/guzzle for acquia#54
714d4cf 
This is the same version of Guzzle used in [Drupal 8.0.0-beta10](http://cgit.drupalcode.org/drupal/tree/core/composer.json?id=8.0.0-beta10#n23).

    $ composer require "guzzlehttp/guzzle:~5.0"
    ./composer.json has been updated
    Loading composer repositories with package information
    Initializing PEAR repository http://pear.php.net
    Updating dependencies (including require-dev)
      - Installing react/promise (v2.2.0)
        Loading from cache

      - Installing guzzlehttp/streams (3.0.0)
        Loading from cache

      - Installing guzzlehttp/ringphp (1.0.7)
        Loading from cache

      - Installing guzzlehttp/guzzle (5.2.0)
        Loading from cache

    Writing lock file
    Generating autoload files
Zlender pushed a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@webbj74-acquia @Zlender
Modifies composer.json dependency on php to >= 5.4.0 for acquia#54
463599e 
PHP 5.4 is the minimum requirement for the following:

- guzzle 5.2.0
- ringphp 1.0.7
- streams 3.0.0
- phploc 2.1.1
- promise v2.2.0

    $ find vendor -name composer.json -exec grep -o ".\bphp\b.:.*" {} \; | sort -u
    "php": ">=5.2.3"
    "php": ">=5.3",
    "php": ">=5.3.0"
    "php": ">=5.3.0",
    "php": ">=5.3.2"
    "php": ">=5.3.2",
    "php": ">=5.3.3"
    "php": ">=5.3.3",
    "php": ">=5.4",
    "php": ">=5.4.0"
    "php": ">=5.4.0",

    $ find vendor -name composer.json -exec grep -H ".\bphp\b.:.*5\.4" {} \; | sort -u
    vendor/guzzlehttp/guzzle/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/ringphp/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/streams/composer.json:        "php": ">=5.4.0"
    vendor/phploc/phploc/composer.json:        "php": ">=5.4",
    vendor/react/promise/composer.json:        "php": ">=5.4.0"

This commit also removes the php 5.3 test environment from Travis CI.
Zlender pushed a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@webbj74-acquia @Zlender
Modified Collection and Element classes to accept \GuzzleHttp\Message…
98ffe61 
…\Response as a constructor arg for acquia#54.

This is a backward-compatible modification to Acquia\Rest\Collection and Acquia\Rest\Element so that the constructor may be used interchangeably with Guzzle 3.x and higher. Since guzzle isn't strictly required for the acquia/acquia-sdk-php-rest sub-package, I've added the old and present versions of Guzzle as composer suggestions, and removed the requirement on Guzzle 3.

The constructor for Acquia\Rest\Collection is no longer strongly typed, but will throw an InvalidArgumentException if an unusual object is passed to it.
Zlender pushed a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@webbj74-acquia @Zlender
WIP: Refactor CloudApiClient to use Guzzle ~5.0 for acquia#54
7fe2c37
Zlender added a commit to Zlender/acquia-sdk-php that referenced this issue Dec 30, 2015
@Zlender
Fixes acquia#54 Switch CloudAPIClient to Guzzle 6
c306ca6
@Zlender Zlender changed the title Upgrade to Guzzle 5 Upgrade to Guzzle 6 Dec 30, 2015
@Zlender Zlender added this to the 2.0 milestone Dec 30, 2015
@IlyaPokamestov
Copy link
Contributor

@cpliakas @Zlender do you have updates? We have some problems with this, because right now we should working with 2 different versions of guzzle in one project. And it's a little bit complex because we should handle different Exception types.

Maybe it will be better to prepare some adapters and decouple guzzle at all? It will be useful because end-user can decide which version he wants to use.

Zlender added a commit to Zlender/acquia-sdk-php that referenced this issue Jan 13, 2017
@Zlender
Fixes acquia#54 Switch CloudAPIClient to Guzzle 6
191916f
@fiasco
Copy link

fiasco commented May 9, 2017

poking this again, updating to Guzzle 6 would be very nice.

@typhonius
Copy link

Adding another comment to this to bump this issue as we're starting to use this library more for our deployments.

typhonius pushed a commit to typhonius/acquia-sdk-php that referenced this issue Jul 24, 2017
@webbj74-acquia @typhonius
Adds composer.json dependency on guzzlehttp/guzzle for acquia#54
7794c2a 
This is the same version of Guzzle used in [Drupal 8.0.0-beta10](http://cgit.drupalcode.org/drupal/tree/core/composer.json?id=8.0.0-beta10#n23).

    $ composer require "guzzlehttp/guzzle:~5.0"
    ./composer.json has been updated
    Loading composer repositories with package information
    Initializing PEAR repository http://pear.php.net
    Updating dependencies (including require-dev)
      - Installing react/promise (v2.2.0)
        Loading from cache

      - Installing guzzlehttp/streams (3.0.0)
        Loading from cache

      - Installing guzzlehttp/ringphp (1.0.7)
        Loading from cache

      - Installing guzzlehttp/guzzle (5.2.0)
        Loading from cache

    Writing lock file
    Generating autoload files
typhonius pushed a commit to typhonius/acquia-sdk-php that referenced this issue Jul 24, 2017
@webbj74-acquia @typhonius
Modifies composer.json dependency on php to >= 5.4.0 for acquia#54
127864a 
PHP 5.4 is the minimum requirement for the following:

- guzzle 5.2.0
- ringphp 1.0.7
- streams 3.0.0
- phploc 2.1.1
- promise v2.2.0

    $ find vendor -name composer.json -exec grep -o ".\bphp\b.:.*" {} \; | sort -u
    "php": ">=5.2.3"
    "php": ">=5.3",
    "php": ">=5.3.0"
    "php": ">=5.3.0",
    "php": ">=5.3.2"
    "php": ">=5.3.2",
    "php": ">=5.3.3"
    "php": ">=5.3.3",
    "php": ">=5.4",
    "php": ">=5.4.0"
    "php": ">=5.4.0",

    $ find vendor -name composer.json -exec grep -H ".\bphp\b.:.*5\.4" {} \; | sort -u
    vendor/guzzlehttp/guzzle/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/ringphp/composer.json:        "php": ">=5.4.0",
    vendor/guzzlehttp/streams/composer.json:        "php": ">=5.4.0"
    vendor/phploc/phploc/composer.json:        "php": ">=5.4",
    vendor/react/promise/composer.json:        "php": ">=5.4.0"

This commit also removes the php 5.3 test environment from Travis CI.
typhonius pushed a commit to typhonius/acquia-sdk-php that referenced this issue Jul 24, 2017
@webbj74-acquia @typhonius
Modified Collection and Element classes to accept \GuzzleHttp\Message…
4527dfc 
…\Response as a constructor arg for acquia#54.

This is a backward-compatible modification to Acquia\Rest\Collection and Acquia\Rest\Element so that the constructor may be used interchangeably with Guzzle 3.x and higher. Since guzzle isn't strictly required for the acquia/acquia-sdk-php-rest sub-package, I've added the old and present versions of Guzzle as composer suggestions, and removed the requirement on Guzzle 3.

The constructor for Acquia\Rest\Collection is no longer strongly typed, but will throw an InvalidArgumentException if an unusual object is passed to it.
typhonius pushed a commit to typhonius/acquia-sdk-php that referenced this issue Jul 24, 2017
@webbj74-acquia @typhonius
WIP: Refactor CloudApiClient to use Guzzle ~5.0 for acquia#54
671ce89
typhonius pushed a commit to typhonius/acquia-sdk-php that referenced this issue Jul 24, 2017
@Zlender @typhonius
Fixes acquia#54 Switch CloudAPIClient to Guzzle 6
b191639
@danepowell
Copy link

danepowell commented Oct 27, 2017 •
edited
Loading

The version of Guzzle being used here (3.x) is almost four years old. That's gotta be insecure, not to mention the fact that it produces numerous warnings whenever a project depending on this sdk is installed.

We'd love to use this in BLT, but I don't know that I'm willing to do so if it's going to produce so many bright yellow deprecation warnings, which will scare and annoy a lot of users. That's going to create a negative image for BLT and Acquia in general.

Can this be prioritized?

Edit: a quick Google reveals at least one known security issue with Guzzle 3, who knows how many more are out there: https://github.com/guzzle/guzzle3/issues/71

@aaronpacheco
Copy link
Contributor

@dane: This repository was maintained by people that no longer work at Acquia. It is currently unsupported.

@skwashd
Copy link

skwashd commented Oct 30, 2017

@aaronpacheco can the readme be upgraded to reflect this?

@aaronpacheco
Copy link
Contributor

Done.

@danepowell
Copy link

Here is a new version of the SDK that uses the v2 Cloud API: https://github.com/typhonius/acquia-php-sdk-v2

I haven't tested that yet, but assuming it's functional, I'd recommend everyone deprecating this and moving to use and support acquia-php-sdk-v2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
9 participants
@skwashd @Zlender @fiasco @geerlingguy @cpliakas @aaronpacheco @danepowell @IlyaPokamestov @typhonius