Set user agent string #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We might need to refactor how we mock the Acquia client service, so that it starts from a common base. Every client call should add this header, but not every test calls the client so the current code won't work. |
grasmash
pushed a commit
that referenced
this pull request
Oct 10, 2020
* Set user agent string * this won't work * fix mock * Fixed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've confirmed this shows up in Sumo Logic as "acli/@package_version@" (with a real version for a phar release)
Also talking about setting a default user agent for the SDK: typhonius/acquia-php-sdk-v2#73