Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1405: LocalMachineHelperTest::testExecuteFromCmd failure #1804

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Sep 26, 2024

Motivation

These tests fail frequently in CI, and only in PHP 8.3. No idea why... possibly a race condition, or i/o issues, or an issue caused by paratest.

Proposed changes

Run these tests in serial.

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (fa517ff) to head (ef19cfb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1804   +/-   ##
=========================================
  Coverage     92.24%   92.24%           
  Complexity     1817     1817           
=========================================
  Files           121      121           
  Lines          6823     6823           
=========================================
  Hits           6294     6294           
  Misses          529      529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danepowell danepowell added the bug Something isn't working label Sep 26, 2024
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1804/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1804/acli.phar
chmod +x acli.phar

@danepowell danepowell marked this pull request as ready for review September 27, 2024 21:30
@danepowell danepowell merged commit 8ad7095 into acquia:main Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant