CLI-1412: [auth:login] PHP warning #1822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes CLI-1412
Proposed changes
I suspect the root cause is keys being an empty array while there’s an active key, which passes the schema validation but obviously isn’t valid.
In troubleshooting this I found a related bug, which is that running auth:logout creates an invalid schema.
The fix in both cases is to adjust the schema validation logic.
Alternatives considered
Testing steps
./bin/acli ckc