Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1412: [auth:login] PHP warning #1822

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

danepowell
Copy link
Contributor

Motivation

Fixes CLI-1412

Proposed changes

I suspect the root cause is keys being an empty array while there’s an active key, which passes the schema validation but obviously isn’t valid.

In troubleshooting this I found a related bug, which is that running auth:logout creates an invalid schema.

The fix in both cases is to adjust the schema validation logic.

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)

@danepowell danepowell added the bug Something isn't working label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (fe3d08f) to head (f31d537).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1822   +/-   ##
=========================================
  Coverage     92.56%   92.56%           
- Complexity     1830     1831    +1     
=========================================
  Files           123      123           
  Lines          6937     6937           
=========================================
  Hits           6421     6421           
  Misses          516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1822/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1822/acli.phar
chmod +x acli.phar

@danepowell danepowell merged commit 440bfc0 into acquia:main Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant