Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for bootstrapping new site with Drupal CMS #1840

Merged
merged 5 commits into from
Jan 10, 2025
Merged

Conversation

balsama
Copy link
Contributor

@balsama balsama commented Jan 7, 2025

Motivation
Adds Drupal CMS to the list of scaffold projects.

Proposed changes
""

Alternatives considered
None

Testing steps
acli app:new:local should show three options including Drupal CMS.

@balsama balsama marked this pull request as draft January 7, 2025 18:06
@danepowell
Copy link
Contributor

Just add me as a reviewer when this is ready for review

Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1840/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1840/acli.phar
chmod +x acli.phar

@balsama balsama marked this pull request as ready for review January 10, 2025 14:44
@balsama balsama requested a review from danepowell January 10, 2025 14:45
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (428a6e2) to head (09cff1d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1840   +/-   ##
=========================================
  Coverage     92.91%   92.92%           
  Complexity     1846     1846           
=========================================
  Files           123      123           
  Lines          6963     6964    +1     
=========================================
+ Hits           6470     6471    +1     
  Misses          493      493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balsama balsama marked this pull request as draft January 10, 2025 15:00
@balsama
Copy link
Contributor Author

balsama commented Jan 10, 2025

Need to check if this will work without a tagged release of the project. Converted back to draft for now.

@balsama
Copy link
Contributor Author

balsama commented Jan 10, 2025

Ok, yeah I need to tag a release of the scaffold project so that the resulting command (composer create-project acquia/drupal-cms-project) works without the stability=dev flag.

But I don't want to create that tag until I sort out why the MySQL 57 module isn't working in IDEs.

@balsama balsama marked this pull request as ready for review January 10, 2025 16:49
@balsama
Copy link
Contributor Author

balsama commented Jan 10, 2025

Ok, all set!

@danepowell danepowell merged commit 8edc651 into main Jan 10, 2025
22 checks passed
@danepowell danepowell deleted the balsama-patch-1 branch January 10, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants