Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svm): L-07 transfer ownership event #838

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Jan 6, 2025

Changes proposed in this PR:
Fix the following issue identified by OZ:

The [transfer_ownership](https://github.com/across-protocol/contracts/blob/0f2600f83e8a5738d0d62a78b05ff37adda4c1c9/programs/svm-spoke/src/instructions/admin.rs#L110) function does not emit any relevant events after performing sensitive actions.

Consider emitting events after sensitive changes take place to facilitate off-chain tracking and monitoring.

md0x added 2 commits January 6, 2025 13:22
Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x changed the title feat(svm): transfer ownership event feat(svm): L-07 transfer ownership event Jan 6, 2025
@md0x md0x marked this pull request as ready for review January 6, 2025 13:44
Comment on lines 11 to 14
event::{
EmergencyDeletedRootBundle, EnabledDepositRoute, PausedDeposits, PausedFills, RelayedRootBundle,
SetXDomainAdmin,
SetXDomainAdmin, TransferredOwnership,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is linted correctly, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants