Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svm): N-06 remove unused instruction attribute #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Reinis-FRP
Copy link
Contributor

OZ identified following issue:

The Accounts derive macro includes an attribute named Instruction that provides access to the instruction’s
arguments within the struct utilizing the macro. However, in the WriteInstructionParamsFragment struct, this
attribute is unnecessary, as neither the offset nor the fragment arguments are used within the struct.

This inclusion may lead to confusion for developers working on the codebase. As such, consider removing the
unused attribute to improve code clarity and maintainability.

This PR addresses the issue by removing the unused instruction attribute.

Copy link

linear bot commented Jan 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants