Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svm): L-02 Missing SpeedUpV3Deposit and FillV3RelayWithUpdatedDe… #848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

md0x
Copy link
Contributor

@md0x md0x commented Jan 8, 2025

Changes proposed in this PR:

  • Fix the following issue identified by OZ:

The speedUpV3Deposit function, implemented in EVM Spoke Pools, allows users to signal updated output amounts, recipient addresses, and messages to the relayer. However, this functionality is not present in the SVM Spoke Pool. Similarly, the fillV3RelayWithUpdatedDeposit function is also absent from the SVM Spoke Pool which is an alternative to the fillV3Relay function for filling deposits. The absence of these two functions creates functional inconsistencies between the EVM and SVM Spoke Pools. As such, this inconsistency could confuse users who expect uniform functionality across platforms and can reduce operational flexibility in managing deposits and relays.

Consider implementing both speedUpV3Deposit and fillV3RelayWithUpdatedDeposit functionalities in the SVM Spoke Pool to align with the EVM Spoke Pools. Alternatively, clearly document their absence to manage user expectations effectively.

We acknowledge this issue but will not implement speed-ups for the following reasons:

Speed-ups are not used often, especially with deposit expirations in place. Previously, they were used to update deposit parameters, but expirations now handle this effectively.

Supporting speed-ups on Solana is overly complex due to incompatible cryptographic schemes. Solana wallets (Ed25519) and Ethereum (ECDSA secp256k1) use different signature algorithms:

While ECDSA signatures from Ethereum wallets can be verified on Solana, Solana wallets cannot generate ECDSA signatures that can be verified on Ethereum.

Speed-ups require the depositor’s signature to be validated on both source and destination chains, which demands a shared signature scheme—something not feasible between Solana and Ethereum.

Given these limitations, we have decided to drop support for speed-ups on Solana.

Added a comment explaining the above.

@md0x md0x marked this pull request as ready for review January 8, 2025 14:42
…posit Functionalities in SVM Spoke Pool

Signed-off-by: Pablo Maldonado <[email protected]>
@md0x md0x force-pushed the pablo/acx-3582-l-02-missing-speedupv3deposit-and branch from 7af2f24 to e2d1882 Compare January 8, 2025 14:42
@md0x md0x marked this pull request as draft January 8, 2025 14:43
Signed-off-by: Chris Maree <[email protected]>
@md0x md0x marked this pull request as ready for review January 8, 2025 14:49
chrismaree
chrismaree previously approved these changes Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants