Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest docker image tags for new releases only #302

Closed
mumoshu opened this issue Feb 12, 2021 · 3 comments · Fixed by #306 or #323
Closed

Use latest docker image tags for new releases only #302

mumoshu opened this issue Feb 12, 2021 · 3 comments · Fixed by #306 or #323
Labels
help wanted Extra attention is needed

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Feb 12, 2021

#300 made me realize that some people use latest tag for the controller image in production deployments. I believe changing our workflow to update latest tag only on new releases makes things a bit more reliable for them.

Currently latest is automatically updated on each new commit in the main branch. As I usually do some additional manual tests before releasing a new version of the controller, updating latest only on new releases result in the controller deployments get updated only with manually tested releases.

From a maintainer's perspective, reports like #300 is SUPER HELPFUL as I can notice/confirm that there's indeed issue(s) that I missed while reviewing or limited manual tests I often do before merging PRs.

So, I'd like to introduce another tag, canary for one that is updated on every commit.

@mumoshu mumoshu added the help wanted Extra attention is needed label Feb 12, 2021
@donovanmuller
Copy link
Contributor

donovanmuller commented Feb 12, 2021

@mumoshu related to this, is there a reason that the Helm chart uses tag: "latest" and not simply a blank value to pick up the appVersion which would be much more stable?

@mumoshu
Copy link
Collaborator Author

mumoshu commented Feb 12, 2021

@donovanmuller Ah, good catch! Probably we'd better just use appVersion and make the default tag empty. I had written tag: "latest" without thinking much.

@callum-tait-pbx
Copy link
Contributor

callum-tait-pbx commented Feb 12, 2021

See my comments on my PR for more details but would it not be better to set the default to latest in the values.yaml that is bundled with the chart, the Helm chart AppVersion really doesn't mean anything for this project. If we change the release workflow as suggested in this issue so that latest is only updated when we are confident it is stable then we shouldn't have a problem in general?

@mumoshu mumoshu reopened this Feb 17, 2021
mumoshu added a commit that referenced this issue Feb 17, 2021
In #306 we seem to have accidentally updated a wrong workflow, which was for runner builds. This updates the one for the controller.

Resolves #302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
3 participants