-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest
docker image tags for new releases only
#302
Comments
@mumoshu related to this, is there a reason that the Helm chart uses |
@donovanmuller Ah, good catch! Probably we'd better just use |
See my comments on my PR for more details but would it not be better to set the default to |
#300 made me realize that some people use
latest
tag for the controller image in production deployments. I believe changing our workflow to updatelatest
tag only on new releases makes things a bit more reliable for them.Currently
latest
is automatically updated on each new commit in the main branch. As I usually do some additional manual tests before releasing a new version of the controller, updatinglatest
only on new releases result in the controller deployments get updated only with manually tested releases.From a maintainer's perspective, reports like #300 is SUPER HELPFUL as I can notice/confirm that there's indeed issue(s) that I missed while reviewing or limited manual tests I often do before merging PRs.
So, I'd like to introduce another tag,
canary
for one that is updated on every commit.The text was updated successfully, but these errors were encountered: