Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another API object to deploy runners backed by StatefulSet #613

Closed
mumoshu opened this issue Jun 8, 2021 · 0 comments · Fixed by #629
Closed

Another API object to deploy runners backed by StatefulSet #613

mumoshu opened this issue Jun 8, 2021 · 0 comments · Fixed by #629
Labels
enhancement New feature or request

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 8, 2021

Last year @summerwind has investigated this idea in #4. As we're wanting to add volumeClaimTemplates to runners #612, it can be better to just restart it, so that we can have volumeClaimTemplates for free.

@mumoshu mumoshu added the enhancement New feature or request label Jun 8, 2021
mumoshu added a commit that referenced this issue Jun 13, 2021
Unlike a runner deployment, a runner set can manage a set of stateful runners by combining a statefulset and an admission webhook that mutates statefulset-managed pods with required envvars and registration tokens.

Resolves #613
Ref #612
mumoshu added a commit that referenced this issue Jun 22, 2021
* feat: RunnerSet backed by StatefulSet

Unlike a runner deployment, a runner set can manage a set of stateful runners by combining a statefulset and an admission webhook that mutates statefulset-managed pods with required envvars and registration tokens.

Resolves #613
Ref #612

* Upgrade controller-runtime to 0.9.0

* Bump Go to 1.16.x following controller-runtime 0.9.0

* Upgrade kubebuilder to 2.3.2 for updated etcd and apiserver following local setup

* Fix startup failure due to missing LeaderElectionID

* Fix the issue that any pods become unable to start once actions-runner-controller got failed after the mutating webhook has been registered

* Allow force-updating statefulset

* Fix runner container missing work and certs-client volume mounts and DOCKER_HOST and DOCKER_TLS_VERIFY envvars when dockerdWithinRunner=false

* Fix runnerset-controller not applying statefulset.spec.template.spec changes when there were no changes in runnerset spec

* Enable running acceptance tests against arbitrary kind cluster

* RunnerSet supports non-ephemeral runners only today

* fix: docker-build from root Makefile on intel mac

* fix: arch check fixes for mac and ARM

* ci: aligning test data format and patching checks

* fix: removing namespace in test data

* chore: adding more ignores

* chore: removing leading space in shebang

* Re-add metrics to org hra testdata

* Bump cert-manager to v1.1.1 and fix deploy.sh

Co-authored-by: toast-gear <[email protected]>
Co-authored-by: Callum James Tait <[email protected]>
mumoshu added a commit that referenced this issue Jun 22, 2021
mumoshu added a commit that referenced this issue Jun 23, 2021
mumoshu added a commit that referenced this issue Jun 23, 2021
`HRA.Spec.ScaleTargetRef.Kind` is added to denote that the scale-target is a RunnerSet.

It defaults to `RunnerDeployment` for backward compatibility.

```
apiVersion: actions.summerwind.dev/v1alpha1
kind: HorizontalRunnerAutoscaler
metadata:
  name: myhra
spec:
  scaleTargetRef:
    kind: RunnerSet
    name: myrunnerset
```

Ref #629
Ref #613
Ref #612
mumoshu added a commit that referenced this issue Jun 24, 2021
mumoshu added a commit that referenced this issue Jun 24, 2021
mumoshu added a commit that referenced this issue Jun 25, 2021
mumoshu added a commit that referenced this issue Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant