Implement dot option #316

kachkaev · 2022-02-04T13:28:20Z

Closes #135

README.md

kachkaev · 2022-02-04T13:32:10Z

README.md

+- path/to/folder/**/*
+- path/to/folder/**/.*


What about path/to/folder/sub/.folder/hello.txt. Will it match? 🤔 If not, what would be the right set of globs?

kachkaev · 2022-09-14T13:56:32Z

@pje, @cory-miller, @rentziass, @thboop 🙏

jdufresne · 2022-09-15T12:37:49Z

README.md

@@ -116,7 +120,23 @@ Various inputs are defined in [`action.yml`](action.yml) to let you configure th
 | `repo-token` | Token to use to authorize label changes. Typically the GITHUB_TOKEN secret, with `contents:read` and `pull-requests:write` access | N/A |
 | `configuration-path` | The path to the label configuration file | `.github/labeler.yml` |
 | `sync-labels` | Whether or not to remove labels when matching files are reverted or no longer changed by the PR | `false`
+| `dot` | Whether or not to auto-include paths starting with dot (e.g. `.github`) | `false`


WDYT about dropping the configuration option and making dot always true.

If someone really wants to ignore dot files, that is another glob expression, right? (Something already supported.) IMO, if we can solve the same problem with less configuration it will be more user friendly and more likely to "do what I mean".

That would be a breaking change which could upset existing users. It’s safer to introduce the option, then wait for a few months, change the default in a major release, wait again and finally remove the option completely.

Yes, I agree it changes the behavior, but perhaps it is a reasonable one. We could also bump the major version to play it safe with expectations. Ultimately, it is not my decision. It is only a suggestion as an end user.

ivoanjo · 2022-09-29T08:47:48Z

+1 Thanks for fixing this, and it would be great if this was merged in. I work at Datadog and we're using this in our repositories (see DataDog/dd-trace-rb#2291).

kachkaev · 2022-10-05T13:38:56Z

README.md

@@ -57,7 +57,7 @@ From a boolean logic perspective, top-level match objects are `OR`-ed together a
 ```yml
 # Add 'label1' to any changes within 'example' folder or any subfolders
 label1:
- example/**/*
+- example/**


Ref: DataDog/dd-trace-rb#2291 (comment)

kachkaev · 2023-01-16T17:41:49Z

@panticmilos @marko-zivic-93 🙏

panticmilos · 2023-01-16T18:54:41Z

hi @kachkaev, we will take a look at this PR :)

## 🌟 What is the purpose of this PR? The aim of this PR is to re-enable Slack notification for changes related to HASH app. It replaces a few globs for `packages/hash/...` with `apps/hash-*/**`, `libs/hash-*/**` and `libs/@local/hash-*/**`. To avoid repetition, I replaced the official labeler versio with the latest commit from actions/labeler#316.   ## 🔗 Related links    - [Asana task](https://app.asana.com/0/1203543026679373/1203800233887959/f) _(internal)_ - [Slack thread](https://hashintel.slack.com/archives/C02THT2LG8N/p1674566469357439) _(internal)_ ## 🐾 Next steps - Check if labeler works (we can only see this once the PR is merged because we use `pull_request_target` as a trigger) - Wait for `dot` option to reach GA and use the official labeler. - We can also consider syncing the labels with BP repo and get rid of `A/B/C-`. This does not bring a lot of added value in short term, so I haven’t tasked that out. ## 🛡 What tests cover this? - Linting - CI in actions/labeler#316

src/labeler.ts

kachkaev · 2023-06-02T12:53:36Z

What else are we missing before the PR can be merged? 🙏

README.md

smorimoto · 2023-06-05T20:15:38Z

I'm glad that this has finally been merged. Thank you for everyone's efforts! 🙂

kachkaev · 2023-06-06T08:13:31Z

v4.1.0 is out with this new option 🎉

If anyone has been using my fork, please switch back to the official labeler action:

-      - uses: kachkaev/labeler@012b89238e3fa57d7af8ee028f02be6d421f184f
-       ## @todo replace with actions/labeler@v4 (or newer) when this PR is merged:
-       ## https://github.com/actions/labeler/pull/316
+     - uses: actions/labeler@v4
        with:
          dot: true

My fork will not receive any updates and I plan to delete it in a couple of months. This means that workflows using kachkaev/labeler will eventually break.

I suggest to make dot: true the default value in actions/labeler@v5 – see #575 (comment). Happy to create a follow-up PR if this makes sense.

After new release of the labeler action, changes to dot files are now tracked. This is available since v4.1. As we're tracking v4, it's going to be automatically picked up and we can make use of the new option. References actions/labeler#316 Fixes solidusio#4804

References actions/labeler#316 Fixes solidusio#4804

References actions/labeler#316 Fixes #4804 (cherry picked from commit edfc321)

MaksimZhukov · 2023-06-06T16:20:21Z

@kachkaev thanks for your time and contribution!
Thank you all for your patience!

kachkaev · 2023-12-05T21:11:56Z

The dot option is true by default in v5 🎉
Release notes: https://github.com/actions/labeler/releases/tag/v5.0.0

Per actions/labeler#316 (comment) the `dot: true` option in `.github/workflows/labeler.yml` can be removed, as `dot` is now set to `true` by default in v5.0.0

kachkaev added 2 commits February 4, 2022 13:26

Implement dot option

b0d9292

Rebuild

6a0b726

kachkaev commented Feb 4, 2022

View reviewed changes

README.md Show resolved Hide resolved

kachkaev commented Feb 4, 2022

View reviewed changes

Fix typo in test caption

409a5a2

kachkaev marked this pull request as ready for review February 4, 2022 13:37

kachkaev requested a review from a team as a code owner February 4, 2022 13:37

kachkaev mentioned this pull request Feb 4, 2022

Action does not match folders starting with dot (.) #135

Closed

kachkaev added 4 commits February 4, 2022 13:47

Add comments

920e9b6

Improve warning

8b8677b

Update README.md

e05b7c1

Update README.md

f3632d3

nefrob mentioned this pull request Sep 6, 2022

Please support minimatch options #434

Closed

Merge remote-tracking branch 'upstream/main' into dot-option

d89797c

jdufresne reviewed Sep 15, 2022

View reviewed changes

kachkaev mentioned this pull request Sep 15, 2022

Update GitHub labels blockprotocol/blockprotocol#613

Merged

kachkaev mentioned this pull request Oct 3, 2022

Action:Automatic pull request labeler DataDog/dd-trace-rb#2291

Merged

Simplify glob

2025154

kachkaev commented Oct 5, 2022

View reviewed changes

kachkaev mentioned this pull request Oct 14, 2022

Update kachkaev/labeler digest to 3194b4b blockprotocol/blockprotocol#659

Closed

1 task

waiting-for-dev mentioned this pull request Jan 9, 2023

PRs with changes only within the .github dir don't get the changelog:repository label solidusio/solidus#4804

Closed

Merge remote-tracking branch 'origin/main' into dot-option

866eff5

kachkaev requested a review from a team as a code owner January 16, 2023 17:36

Rebuild

305cfeb

kachkaev mentioned this pull request Jan 24, 2023

Update labeler config hashintel/hash#1934

Merged

kachkaev added 2 commits May 31, 2023 01:50

Rebuild

673c7e2

Further diff reduction

e3b3815

kachkaev requested a review from AndreiLobanovich May 31, 2023 01:04

MaksimZhukov reviewed May 31, 2023

View reviewed changes

src/labeler.ts Outdated Show resolved Hide resolved

kachkaev added 2 commits May 31, 2023 17:23

Remove required: false

54d434d

Rebuild

59d3310

kachkaev requested a review from MaksimZhukov May 31, 2023 16:32

kachkaev added 2 commits May 31, 2023 18:46

Address review comment

71d2484

Rebuild

639ba81

AndreiLobanovich approved these changes Jun 2, 2023

View reviewed changes

AndreiLobanovich reviewed Jun 2, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

micromatch → minimatch

d40596e

MaksimZhukov approved these changes Jun 5, 2023

View reviewed changes

IvanZosimov approved these changes Jun 5, 2023

View reviewed changes

MaksimZhukov merged commit 82a4f6f into actions:main Jun 5, 2023

kachkaev deleted the dot-option branch June 5, 2023 09:51

kachkaev mentioned this pull request Jun 5, 2023

v5.0.0-alpha.1 #575

Closed

waiting-for-dev mentioned this pull request Jun 6, 2023

Fix changelog tracking for dot files solidusio/solidus#5122

Merged

3 tasks

waiting-for-dev added a commit to nebulab/solidus that referenced this pull request Jun 6, 2023

Fix changelog tracking for dot files

edfc321

References actions/labeler#316 Fixes solidusio#4804

github-actions bot pushed a commit to solidusio/solidus that referenced this pull request Jun 6, 2023

Fix changelog tracking for dot files

8ad2211

References actions/labeler#316 Fixes #4804 (cherry picked from commit edfc321)

github-actions bot pushed a commit to solidusio/solidus that referenced this pull request Jun 6, 2023

Fix changelog tracking for dot files

8640773

References actions/labeler#316 Fixes #4804 (cherry picked from commit edfc321)

github-actions bot pushed a commit to solidusio/solidus that referenced this pull request Jun 6, 2023

Fix changelog tracking for dot files

9cc1381

References actions/labeler#316 Fixes #4804 (cherry picked from commit edfc321)

github-actions bot pushed a commit to solidusio/solidus that referenced this pull request Jun 6, 2023

Fix changelog tracking for dot files

50b9bd6

References actions/labeler#316 Fixes #4804 (cherry picked from commit edfc321)

vilkinsons added a commit to hashintel/hash that referenced this pull request Dec 5, 2023

Stop explicitly specifying dot: true

451e9cf

Per actions/labeler#316 (comment) the `dot: true` option in `.github/workflows/labeler.yml` can be removed, as `dot` is now set to `true` by default in v5.0.0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement dot option #316

Implement dot option #316

kachkaev commented Feb 4, 2022 •

edited

Loading

kachkaev Feb 4, 2022

kachkaev commented Sep 14, 2022 •

edited

Loading

jdufresne Sep 15, 2022

kachkaev Sep 15, 2022 •

edited

Loading

jdufresne Sep 15, 2022 •

edited

Loading

ivoanjo commented Sep 29, 2022

kachkaev Oct 5, 2022

kachkaev commented Jan 16, 2023 •

edited

Loading

panticmilos commented Jan 16, 2023

kachkaev commented Jun 2, 2023

smorimoto commented Jun 5, 2023

kachkaev commented Jun 6, 2023 •

edited

Loading

MaksimZhukov commented Jun 6, 2023

kachkaev commented Dec 5, 2023 •

edited

Loading

Implement dot option #316

Implement dot option #316

Conversation

kachkaev commented Feb 4, 2022 • edited Loading

kachkaev Feb 4, 2022

Choose a reason for hiding this comment

kachkaev commented Sep 14, 2022 • edited Loading

jdufresne Sep 15, 2022

Choose a reason for hiding this comment

kachkaev Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

jdufresne Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

ivoanjo commented Sep 29, 2022

kachkaev Oct 5, 2022

Choose a reason for hiding this comment

kachkaev commented Jan 16, 2023 • edited Loading

panticmilos commented Jan 16, 2023

kachkaev commented Jun 2, 2023

smorimoto commented Jun 5, 2023

kachkaev commented Jun 6, 2023 • edited Loading

MaksimZhukov commented Jun 6, 2023

kachkaev commented Dec 5, 2023 • edited Loading

kachkaev commented Feb 4, 2022 •

edited

Loading

kachkaev commented Sep 14, 2022 •

edited

Loading

kachkaev Sep 15, 2022 •

edited

Loading

jdufresne Sep 15, 2022 •

edited

Loading

kachkaev commented Jan 16, 2023 •

edited

Loading

kachkaev commented Jun 6, 2023 •

edited

Loading

kachkaev commented Dec 5, 2023 •

edited

Loading