-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Error message for missing config file #475
Merged
MaksimZhukov
merged 7 commits into
actions:main
from
Gornoka:error_message_for_missing_conf_rebase
Jun 30, 2023
Merged
Improved Error message for missing config file #475
MaksimZhukov
merged 7 commits into
actions:main
from
Gornoka:error_message_for_missing_conf_rebase
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiLobanovich
suggested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, @Gornoka!
Thank you for your contribution!
Please, resolve conflicts and consider proposed change. Then we will be happy to merge your PR.
Gornoka
force-pushed
the
error_message_for_missing_conf_rebase
branch
2 times, most recently
from
June 28, 2023 20:50
cc660a6
to
375538a
Compare
Co-authored-by: AndreiLobanovich <[email protected]>
thanks for the feedback, i messed up with the webui a little, pr will be open again soon |
AndreiLobanovich
suggested changes
Jun 29, 2023
MaksimZhukov
approved these changes
Jun 30, 2023
dmitry-shibanov
approved these changes
Jun 30, 2023
IvanZosimov
approved these changes
Jun 30, 2023
AndreiLobanovich
approved these changes
Jun 30, 2023
@Gornoka thank you for the contribution! |
github-merge-queue bot
referenced
this pull request
in owntracks/android
Jul 11, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/labeler](https://togithub.com/actions/labeler) | action | minor | `v4.2.0` -> `v4.3.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>actions/labeler (actions/labeler)</summary> ### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0) [Compare Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0) #### What's Changed In scope of this release, the ability to specify pull request number(s) was added by [@​credfeto](https://togithub.com/credfeto) in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349). Support for reading from the configuration file presented on the runner was added by [@​lrstanley](https://togithub.com/lrstanley) in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394). It allows you to use a configuration file generated during workflow run or uploaded from a separate repository. Please refer to the [action documentation](https://togithub.com/actions/labeler#inputs) for more information. This release also includes the following changes: - Improved Error message for missing config file by [@​Gornoka](https://togithub.com/Gornoka) in [https://github.com/actions/labeler/pull/475](https://togithub.com/actions/labeler/pull/475) - Early exit when no files are changed by [@​nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) - Add examples to match all repo files by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/600](https://togithub.com/actions/labeler/pull/600) - Fix a typo in the example about using the action outputs by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/606](https://togithub.com/actions/labeler/pull/606) - Bump eslint from 8.43.0 to 8.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/601](https://togithub.com/actions/labeler/pull/601) - Bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/602](https://togithub.com/actions/labeler/pull/602) - Bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/604](https://togithub.com/actions/labeler/pull/604) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/609](https://togithub.com/actions/labeler/pull/609) - Bump [@​octokit/plugin-retry](https://togithub.com/octokit/plugin-retry) from 5.0.4 to 5.0.5 by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/610](https://togithub.com/actions/labeler/pull/610) #### New Contributors - [@​credfeto](https://togithub.com/credfeto) made their first contribution in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349) - [@​lrstanley](https://togithub.com/lrstanley) made their first contribution in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394) - [@​nathanhammond](https://togithub.com/nathanhammond) made their first contribution in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) **Full Changelog**: actions/labeler@v4...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/owntracks/android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot
referenced
this pull request
in owntracks/android
Jul 11, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/labeler](https://togithub.com/actions/labeler) | action | minor | `v4.2.0` -> `v4.3.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>actions/labeler (actions/labeler)</summary> ### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0) [Compare Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0) #### What's Changed In scope of this release, the ability to specify pull request number(s) was added by [@​credfeto](https://togithub.com/credfeto) in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349). Support for reading from the configuration file presented on the runner was added by [@​lrstanley](https://togithub.com/lrstanley) in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394). It allows you to use a configuration file generated during workflow run or uploaded from a separate repository. Please refer to the [action documentation](https://togithub.com/actions/labeler#inputs) for more information. This release also includes the following changes: - Improved Error message for missing config file by [@​Gornoka](https://togithub.com/Gornoka) in [https://github.com/actions/labeler/pull/475](https://togithub.com/actions/labeler/pull/475) - Early exit when no files are changed by [@​nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) - Add examples to match all repo files by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/600](https://togithub.com/actions/labeler/pull/600) - Fix a typo in the example about using the action outputs by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/606](https://togithub.com/actions/labeler/pull/606) - Bump eslint from 8.43.0 to 8.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/601](https://togithub.com/actions/labeler/pull/601) - Bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/602](https://togithub.com/actions/labeler/pull/602) - Bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/604](https://togithub.com/actions/labeler/pull/604) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/609](https://togithub.com/actions/labeler/pull/609) - Bump [@​octokit/plugin-retry](https://togithub.com/octokit/plugin-retry) from 5.0.4 to 5.0.5 by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/610](https://togithub.com/actions/labeler/pull/610) #### New Contributors - [@​credfeto](https://togithub.com/credfeto) made their first contribution in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349) - [@​lrstanley](https://togithub.com/lrstanley) made their first contribution in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394) - [@​nathanhammond](https://togithub.com/nathanhammond) made their first contribution in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) **Full Changelog**: actions/labeler@v4...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/owntracks/android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
flookapa
referenced
this pull request
in flookapa/owntracks_android
Aug 27, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/labeler](https://togithub.com/actions/labeler) | action | minor | `v4.2.0` -> `v4.3.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the logs for more information. --- ### Release Notes <details> <summary>actions/labeler (actions/labeler)</summary> ### [`v4.3.0`](https://togithub.com/actions/labeler/releases/tag/v4.3.0) [Compare Source](https://togithub.com/actions/labeler/compare/v4.2.0...v4.3.0) #### What's Changed In scope of this release, the ability to specify pull request number(s) was added by [@​credfeto](https://togithub.com/credfeto) in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349). Support for reading from the configuration file presented on the runner was added by [@​lrstanley](https://togithub.com/lrstanley) in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394). It allows you to use a configuration file generated during workflow run or uploaded from a separate repository. Please refer to the [action documentation](https://togithub.com/actions/labeler#inputs) for more information. This release also includes the following changes: - Improved Error message for missing config file by [@​Gornoka](https://togithub.com/Gornoka) in [https://github.com/actions/labeler/pull/475](https://togithub.com/actions/labeler/pull/475) - Early exit when no files are changed by [@​nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) - Add examples to match all repo files by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/600](https://togithub.com/actions/labeler/pull/600) - Fix a typo in the example about using the action outputs by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/606](https://togithub.com/actions/labeler/pull/606) - Bump eslint from 8.43.0 to 8.44.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/601](https://togithub.com/actions/labeler/pull/601) - Bump [@​typescript-eslint/parser](https://togithub.com/typescript-eslint/parser) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/602](https://togithub.com/actions/labeler/pull/602) - Bump [@​typescript-eslint/eslint-plugin](https://togithub.com/typescript-eslint/eslint-plugin) from 5.60.1 to 5.61.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/604](https://togithub.com/actions/labeler/pull/604) - Bump tough-cookie from 4.1.2 to 4.1.3 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/labeler/pull/609](https://togithub.com/actions/labeler/pull/609) - Bump [@​octokit/plugin-retry](https://togithub.com/octokit/plugin-retry) from 5.0.4 to 5.0.5 by [@​MaksimZhukov](https://togithub.com/MaksimZhukov) in [https://github.com/actions/labeler/pull/610](https://togithub.com/actions/labeler/pull/610) #### New Contributors - [@​credfeto](https://togithub.com/credfeto) made their first contribution in [https://github.com/actions/labeler/pull/349](https://togithub.com/actions/labeler/pull/349) - [@​lrstanley](https://togithub.com/lrstanley) made their first contribution in [https://github.com/actions/labeler/pull/394](https://togithub.com/actions/labeler/pull/394) - [@​nathanhammond](https://togithub.com/nathanhammond) made their first contribution in [https://github.com/actions/labeler/pull/456](https://togithub.com/actions/labeler/pull/456) **Full Changelog**: actions/labeler@v4...v4.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/owntracks/android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNi41LjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changed error message for missing/misconfigured/misnamed config file.
Related issue:
this should help people to identify this issue quickly
Check list: