Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "revert node12 version due to fs.copyFileSync hang https://git… #1651

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Revert "revert node12 version due to fs.copyFileSync hang https://git… #1651

merged 4 commits into from
Feb 17, 2022

Conversation

thboop
Copy link
Collaborator

@thboop thboop commented Feb 2, 2022

…hub.com//issues/1536 (#1537)"

bef164a

Now that the kernel is fixed, lets update node12 again.

Resolves #1536

@thboop thboop requested a review from a team as a code owner February 2, 2022 20:41
TingluoHuang
TingluoHuang previously approved these changes Feb 2, 2022
View reviewed changes
@thboop thboop force-pushed the thboop/updatenode12 branch 2 times, most recently from be8439d to d40d3ca Compare February 8, 2022 14:54
@thboop thboop merged commit 17153c9 into main Feb 17, 2022
@thboop thboop deleted the thboop/updatenode12 branch February 17, 2022 14:54
fhammerl pushed a commit that referenced this pull request Feb 24, 2022
@thboop
Revert "revert node12 version due to fs.copyFileSync hang https://git… (
493a0bd 
#1651)

* Revert "revert node12 version due to fs.copyFileSync hang #1536 (#1537)"

bef164a

* check hashs before tests because tests rely on right values + update hashes

* fix tests

* use hc trace
@jeremyd2019
Copy link
Contributor

jeremyd2019 commented Feb 25, 2022 •
edited
Loading

the release notes for v2.288.0 say "Bump node12 version to latest" but 12.22.7 is not the latest, I think 12.22.10 may be the latest (but I'm no node.js expert).

@crazy-max crazy-max mentioned this pull request Mar 1, 2022
Closed
@crazy-max
Copy link

crazy-max commented Mar 1, 2022 •
edited
Loading

This PR seems to break users since v2.288.0: docker/setup-buildx-action#117 (comment). The node update has been already reverted in #1537 (cc @ericsciple) but this PR basically puts the exact same version back with the fs.copyFileSync hanging issue.

How could we know if the kernel issue is fixed? Thx.

@TingluoHuang
Copy link
Member

@crazy-max base on #1536
the Linux kernel bug has been patched in 5.4, and both AWS and Azure have this patch in their latest VM image.

@crazy-max
Copy link

@TingluoHuang Ok thanks! Maybe this user uses the runner on a kernel that is not patched yet. Sorry for the noise.

@crazy-max
Copy link

Looks like this is tracked in https://bugs.launchpad.net/ubuntu/+source/linux-base/+bug/1953199

@crazy-max
Copy link

crazy-max commented Mar 1, 2022 •
edited
Loading

@TingluoHuang As nodejs is core component, I wonder if the runner instance could be smart enough to detect kernels that can cause issues like this. Maybe a warning message or set a minimal required kernel version in the runner config that says to upgrade the kernel before making an update of the runner?

@TingluoHuang
Copy link
Member

@crazy-max it's kernel + overlay filesystem combined that exposes the bug. 😢 it might be harder to detect the filesystem when you are inside it.

@crazy-max
Copy link

@TingluoHuang Ah yeah true might be tricky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingluoHuang TingluoHuang TingluoHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs.copyFileSync hangs for file created within same layer in overlay filesystem
4 participants
@thboop @jeremyd2019 @crazy-max @TingluoHuang