Use better exit codes and comparison #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thboop
reviewed
Feb 22, 2022
TingluoHuang
added a commit
that referenced
this pull request
Apr 19, 2022
This reverts commit 6abef81.
TingluoHuang
added a commit
that referenced
this pull request
Apr 19, 2022
* Revert "Use better exit codes and comparison (#1708)" This reverts commit 6abef81. * Revert "fix run.cmd script (#1633)" This reverts commit 192ebfe. * Revert "Reopen 'Make run.sh|cmd handle update without quitting so containers using them as entrypoints don't exit on update ' (#1646)" This reverts commit 8f160bc. * Release 2.289.3 runner.
jenseng
added a commit
to jenseng/runner
that referenced
this pull request
Jul 26, 2024
- Propagate non-zero exit codes up through run.sh/run.cmd/runsvc.sh - Ensure .cmd scripts use 2 for retries (as was done for .sh in actions#1708) Fixes actions#2769 Supersedes actions#2719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exiting with
exit 1inrun-helper.shand then reacting to it withif [[ $returnCode == 1 ]]; thenwill also restart on generic errors occuring in run-helper, like how weexit 1inrun-helper.sh(line 7) if it's run with sudo.I suggest we indicate a restart request with
exit 2, then react to it withif [[ $returnCode -eq 2 ]]; thenAlso changes
==to-eqfor numerical comparison.