Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to recommend VS code 2019 #524

Closed
wants to merge 1 commit into from
Closed

Update documentation to recommend VS code 2019 #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/contribute.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,9 @@ cd ./src
### Editors

[Using Visual Studio Code](https://code.visualstudio.com/)
[Using Visual Studio](https://code.visualstudio.com/docs)

[Using Visual Studio](https://code.visualstudio.com/docs)
We recommend using [Visual Studio 2019](https://visualstudio.microsoft.com/vs/) since it has built in support for .NET and other libraries that are helpful for contributing and running this repo while newer versions of Visual Studio does not have support for these libraries as of yet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the older VS version might not work with dotnet core, not the newer version.

What error do you get?

I would not say We recommend using [Visual Studio 2019] since VsCode is a better IDE for this repo since the runner is for Windows/Linux/macOS, but you can only use VS in Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a lot of issues with omnisharp like: dotnet/vscode-csharp#2507. But when I reinstall Visual Studio Code, the error disappeared and I wasn't able to replicate it so I'm not sure what's going on. I'll close this PR for now :P

### Styling

We use the .NET Foundation and CoreCLR style guidelines [located here](
Expand Down