Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-dist.yml #206

Closed
wants to merge 1 commit into from
Closed

Add check-dist.yml #206

wants to merge 1 commit into from

Conversation

konradpabjan
Copy link
Collaborator

This adds a workflow to check the contents of the checked-in dist/index.js against the expected version.

See actions/upload-artifact#227 for background and rationale.

Similar PR: actions/download-artifact#108

@KengoTODA
Copy link
Contributor

note that we have similar comparison in the build.yml:

- name: Verify no unstaged changes
if: runner.os != 'windows'
run: bash __tests__/verify-no-unstaged-changes.sh

It runs verify-no-unstaged-changes.sh in the __tests__ dir.

@maxim-lobanov
Copy link
Contributor

@konradpabjan , agree with @KengoTODA . In build.yml we do pretty similar check: https://github.com/actions/setup-java/blob/main/__tests__/verify-no-unstaged-changes.sh
I think it should be enough.

@konradpabjan
Copy link
Collaborator Author

🤦‍♂️ Disregard. Thanks everyone!

@konradpabjan konradpabjan deleted the konradpabjan/check-dist branch May 19, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants