Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "check-latest" flag to check if pre-cached version is latest one #165

Merged
merged 6 commits into from
Jun 29, 2020
Merged

Implement "check-latest" flag to check if pre-cached version is latest one #165

merged 6 commits into from
Jun 29, 2020

Conversation

maxim-lobanov
Copy link
Contributor

@maxim-lobanov maxim-lobanov commented Jun 22, 2020 •
edited
Loading

Issue: #160

Add check-latest flag and implementation

Additional changes:

  1. Add tests
  2. Significantly extend test matrix in versions.yml

@konradpabjan
Copy link
Contributor

konradpabjan commented Jun 23, 2020 •
edited
Loading

Some updates to the README regarding the new input would be good. Not everyone looks at action.yml to get the list of all available inputs.

An example with check-latest set to true would be good alongside an explanation of why users would want to us this (what specific use cases does this solve or fix). Here you can also mention the default behavior.

konradpabjan
konradpabjan reviewed Jun 23, 2020
View reviewed changes
src/installer.ts Outdated Show resolved Hide resolved
@maxim-lobanov
Copy link
Contributor Author

Some updates to the README regarding the new input would be good. Not everyone looks at action.yml to get the list of all available inputs.

An example with check-latest set to true would be good alongside an explanation of why users would want to us this (what specific use cases does this solve or fix). Here you can also mention the default behavior.

@konradpabjan , Updated readme. Please let me know if we can find better words to explain flag purpose

bryanmacfarlane
bryanmacfarlane reviewed Jun 29, 2020
View reviewed changes
src/installer.ts Outdated Show resolved Hide resolved
bryanmacfarlane
bryanmacfarlane reviewed Jun 29, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bryanmacfarlane
Copy link
Member

I added a few notes. Outside of that, I'm good with the change.

@bryanmacfarlane bryanmacfarlane merged commit 1ae8f4b into actions:master Jun 29, 2020
@dmitry-shibanov dmitry-shibanov mentioned this pull request Nov 1, 2021
Closed
deining pushed a commit to deining/setup-node that referenced this pull request Nov 9, 2023
@dependabot @EndBug
chore(deps-dev): bump eslint-config-prettier from 6.15.0 to 8.1.0 (ac…
0d021d8 
…tions#165)

* chore(deps-dev): bump eslint-config-prettier from 6.15.0 to 8.1.0

Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.15.0 to 8.1.0.
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v6.15.0...v8.1.0)

Signed-off-by: dependabot[bot] <[email protected]>

* chore: update eslint config

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Federico Grandi <[email protected]>
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this pull request Mar 30, 2024
@undergroundwires
ci/cd: bump Node.js environment to 20.x
b0136e3 
This commit upgrades Node.js version to v20.x in CI/CD environment.

Previously used Node 18.x is moving towards end-of-life, with a planned
date of 2025-04-30. In contrast, Node 20.x has been offering long-term
support (LTS) since 2023-10-24. This makes Node 20.x a stable and
recommended version for production environments.

This commit also configures `actions/setup-node` with the
`check-latest` flag to always use the latest Node 20.x version, keeping
CI/CD setup up-to-date with minimal maintenance.
Details:
- actions/setup-node#165
- actions/setup-node#160

Using Node 20.x in CI/CD environments provides better compatibility with
Electron v29.0 which moves to Node 20.x.
Details:
- electron/electron#40343

This upgrade improves network connection handling in CI/CD pipelines
(where issues occur due to GitHub runners not supporting IPv6).
Details:
- actions/runner#3138
- actions/runner-images#668
- actions/runner#3213
- actions/runner-images#9540

Node 20.x adopts the Happy Eyeballs algorithm for improved IPv6
connectivity.
- nodejs/node#40702
- nodejs/node#41625
- nodejs/node#44731

This mitigates issues like `UND_ERR_CONNECT_TIMEOUT` and localhost DNS
resolution in CI/CD environments:
Details:
- nodejs/node#40537
- actions/runner#3213
- actions/runner-images#9540

Node 20 introduces `setDefaultAutoSelectFamily`, a global function from
Node 19.4.0, enabling better IPv4 support, especially in environments
with limited or problematic IPv6 support.
Details:
- nodejs/node#45777

Node 20.x defaults to the new `autoSelectFamily`, improving network
connection reliability in GitHub runners lacking full IPv6 support.
Details:
- nodejs/node#46790
undergroundwires added a commit to undergroundwires/privacy.sexy that referenced this pull request Mar 30, 2024
@undergroundwires
ci/cd: bump Node.js environment to 20.x
59decd1 
This commit upgrades Node.js version to v20.x in CI/CD environment.

Previously used Node 18.x is moving towards end-of-life, with a planned
date of 2025-04-30. In contrast, Node 20.x has been offering long-term
support (LTS) since 2023-10-24. This makes Node 20.x a stable and
recommended version for production environments.

This commit also configures `actions/setup-node` with the
`check-latest` flag to always use the latest Node 20.x version, keeping
CI/CD setup up-to-date with minimal maintenance.
Details:
- actions/setup-node#165
- actions/setup-node#160

Using Node 20.x in CI/CD environments provides better compatibility with
Electron v29.0 which moves to Node 20.x.
Details:
- electron/electron#40343

This upgrade improves network connection handling in CI/CD pipelines
(where issues occur due to GitHub runners not supporting IPv6).
Details:
- actions/runner#3138
- actions/runner-images#668
- actions/runner#3213
- actions/runner-images#9540

Node 20.x adopts the Happy Eyeballs algorithm for improved IPv6
connectivity.
- nodejs/node#40702
- nodejs/node#41625
- nodejs/node#44731

This mitigates issues like `UND_ERR_CONNECT_TIMEOUT` and localhost DNS
resolution in CI/CD environments:
Details:
- nodejs/node#40537
- actions/runner#3213
- actions/runner-images#9540

Node 20 introduces `setDefaultAutoSelectFamily`, a global function from
Node 19.4.0, enabling better IPv4 support, especially in environments
with limited or problematic IPv6 support.
Details:
- nodejs/node#45777

Node 20.x defaults to the new `autoSelectFamily`, improving network
connection reliability in GitHub runners lacking full IPv6 support.
Details:
- nodejs/node#46790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradpabjan konradpabjan konradpabjan left review comments

@bryanmacfarlane bryanmacfarlane bryanmacfarlane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxim-lobanov @konradpabjan @bryanmacfarlane @usandourkids525