Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new cache service: upgrade @actions/cache to ^4.0.0 #1007

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

priyagupta108
Copy link
Contributor

Description:
Following the announcement of the sunsetting of the legacy actions cache service & the deprecation of several versions of the @actions/cache package, this change upgrades setup-python to the latest cache package to prevent cache failures when the sunsetting start.

Related issue:
#1004

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@priyagupta108 priyagupta108 requested a review from a team as a code owner January 14, 2025 13:03
@priyagupta108 priyagupta108 self-assigned this Jan 15, 2025
@HarithaVattikuti HarithaVattikuti merged commit b8cf3eb into actions:main Jan 21, 2025
424 checks passed
Copy link

@invisiblepancake invisiblepancake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependency Updates:

Make sure the new version of @actions/cache doesn't introduce any unexpected bugs. We don't want any "cache cowboys" causing trouble!
Workflow Changes:

Verify that the poetry install --no-root command works correctly. Poetry should be installing dependencies, not writing sonnets.
License Files:

Ensure the new .licenses/npm files are correctly formatted and necessary. We need to make sure we're not accidentally licensing our code to extraterrestrials.
General Sanity Check:

Confirm that all changes make sense and align with the project goals. If anything seems off, it might be a sign of some rogue AI trying to take over our repository.
Humor Check:

Double-check that the commit messages maintain a professional tone. We can laugh internally, but let's keep the commit history clear and concise.
Code Consistency:

Ensure that the code style remains consistent. We wouldn't want our code looking like it has a split personality.
Remember, these criteria are meant to be amusing but also to ensure a thorough review. Let's keep our codebase both functional and fun!

allenporter pushed a commit to allenporter/flux-local that referenced this pull request Jan 31, 2025
### Notes
I noticed when implementing `action/test` the caching step took a
significant amount of time compared to the actual business logic.
`action/diff` doesn't seem to have this behavior.

`action/diff` is using `actions/setup-python@v5`, while `action/test` is
using `actions/setup-python@v4`.

This is important as that action has updated `actions/cache@v4` which
uses the newer V2 cache. Additionally, all prior versions of
`actions/cache` will start failing in workflows on 2025-02-01.

Solution is to update `actions/setup-python` to the latest version.

### References

- actions/setup-python#1007
- actions/toolkit#1890
mergify bot added a commit to ArcadeData/arcadedb that referenced this pull request Feb 3, 2025
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.3.0 to 5.4.0.
Release notes

*Sourced from [actions/setup-python's releases](https://github.com/actions/setup-python/releases).*

> v5.4.0
> ------
> 
> What's Changed
> --------------
> 
> ### Enhancements:
> 
> * Update cache error message by [`@​aparnajyothi-y`](https://github.com/aparnajyothi-y) in [actions/setup-python#968](https://redirect.github.com/actions/setup-python/pull/968)
> * Enhance Workflows: Add Ubuntu-24, Remove Python 3.8 by [`@​priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-python#985](https://redirect.github.com/actions/setup-python/pull/985)
> * Configure Dependabot settings by [`@​HarithaVattikuti`](https://github.com/HarithaVattikuti) in [actions/setup-python#1008](https://redirect.github.com/actions/setup-python/pull/1008)
> 
> ### Documentation changes:
> 
> * Readme update - recommended permissions by [`@​benwells`](https://github.com/benwells) in [actions/setup-python#1009](https://redirect.github.com/actions/setup-python/pull/1009)
> * Improve Advanced Usage examples by [`@​lrq3000`](https://github.com/lrq3000) in [actions/setup-python#645](https://redirect.github.com/actions/setup-python/pull/645)
> 
> ### Dependency updates:
> 
> * Upgrade `undici` from 5.28.4 to 5.28.5 by [`@​dependabot`](https://github.com/dependabot) in [actions/setup-python#1012](https://redirect.github.com/actions/setup-python/pull/1012)
> * Upgrade `urllib3` from 1.25.9 to 1.26.19 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot) in [actions/setup-python#895](https://redirect.github.com/actions/setup-python/pull/895)
> * Upgrade `actions/publish-immutable-action` from 0.0.3 to 0.0.4 by [`@​dependabot`](https://github.com/dependabot) in [actions/setup-python#1014](https://redirect.github.com/actions/setup-python/pull/1014)
> * Upgrade `@actions/http-client` from 2.2.1 to 2.2.3 by [`@​dependabot`](https://github.com/dependabot) in [actions/setup-python#1020](https://redirect.github.com/actions/setup-python/pull/1020)
> * Upgrade `requests` from 2.24.0 to 2.32.2 in /**tests**/data by [`@​dependabot`](https://github.com/dependabot) in [actions/setup-python#1019](https://redirect.github.com/actions/setup-python/pull/1019)
> * Upgrade `@actions/cache` to `^4.0.0` by [`@​priyagupta108`](https://github.com/priyagupta108) in [actions/setup-python#1007](https://redirect.github.com/actions/setup-python/pull/1007)
> 
> New Contributors
> ----------------
> 
> * [`@​benwells`](https://github.com/benwells) made their first contribution in [actions/setup-python#1009](https://redirect.github.com/actions/setup-python/pull/1009)
> * [`@​HarithaVattikuti`](https://github.com/HarithaVattikuti) made their first contribution in [actions/setup-python#1008](https://redirect.github.com/actions/setup-python/pull/1008)
> * [`@​lrq3000`](https://github.com/lrq3000) made their first contribution in [actions/setup-python#645](https://redirect.github.com/actions/setup-python/pull/645)
> 
> **Full Changelog**: <actions/setup-python@v5...v5.4.0>


Commits

* [`4237552`](actions/setup-python@4237552) Improve Advanced Usage examples ([#645](https://redirect.github.com/actions/setup-python/issues/645))
* [`709bfa5`](actions/setup-python@709bfa5) Bump requests from 2.24.0 to 2.32.2 in /**tests**/data ([#1019](https://redirect.github.com/actions/setup-python/issues/1019))
* [`ceb20b2`](actions/setup-python@ceb20b2) Bump `@​actions/http-client` from 2.2.1 to 2.2.3 ([#1020](https://redirect.github.com/actions/setup-python/issues/1020))
* [`0dc2d2c`](actions/setup-python@0dc2d2c) Bump actions/publish-immutable-action from 0.0.3 to 0.0.4 ([#1014](https://redirect.github.com/actions/setup-python/issues/1014))
* [`feb9c6e`](actions/setup-python@feb9c6e) Bump urllib3 from 1.25.9 to 1.26.19 in /**tests**/data ([#895](https://redirect.github.com/actions/setup-python/issues/895))
* [`d0b4fc4`](actions/setup-python@d0b4fc4) Bump undici from 5.28.4 to 5.28.5 ([#1012](https://redirect.github.com/actions/setup-python/issues/1012))
* [`e3dfaac`](actions/setup-python@e3dfaac) Configure Dependabot settings ([#1008](https://redirect.github.com/actions/setup-python/issues/1008))
* [`b8cf3eb`](actions/setup-python@b8cf3eb) Use the new cache service: upgrade `@actions/cache` to `^4.0.0` ([#1007](https://redirect.github.com/actions/setup-python/issues/1007))
* [`1928ae6`](actions/setup-python@1928ae6) Update README.md ([#1009](https://redirect.github.com/actions/setup-python/issues/1009))
* [`3fddbee`](actions/setup-python@3fddbee) Enhance Workflows: Add Ubuntu-24, Remove Python 3.8 ([#985](https://redirect.github.com/actions/setup-python/issues/985))
* Additional commits viewable in [compare view](actions/setup-python@0b93645...4237552)

  

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=actions/setup-python&package-manager=github\_actions&previous-version=5.3.0&new-version=5.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants