Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python-version in the example for consistency #25

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 15, 2019

version is deprecated in 6f6fcee and python-version should be used instead, like in the README:

jobs:
  build:
    runs-on: ubuntu-16.04
    strategy:
      matrix:
        python: [ '2.x', '3.x', 'pypy3' ]
    name: Python ${{ matrix.python }} sample
    steps:
      - uses: actions/checkout@master
      - name: Setup python
        uses: actions/setup-python@v1
        with:
          python-version: ${{ matrix.python }}
          architecture: x64
      - run: python my_script.py

I wanted a step to only run for a certain Python version, and at first tried checking for matrix.python-version, but it's really matrix.python with the current README:

    - name: Docs
      if: matrix.python == 2.7
      run: |
        pip install sphinx-rtd-theme
        make doccheck

To make things clearer, use python-version in the example for both, as in this PR, so no need to think about two similar but different names, and we can use this:

    - name: Docs
      if: matrix.python-version == 2.7
      run: |
        pip install sphinx-rtd-theme
        make doccheck

Plus fix a couple of "python" -> "Python" typos.

Copy link

@Schlopper Schlopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk - Thank you for your contribution!

@madhurig madhurig merged commit 1396627 into actions:master Oct 28, 2019
@hugovk hugovk deleted the patch-2 branch October 28, 2019 15:41
@hugovk
Copy link
Contributor Author

hugovk commented Oct 28, 2019

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants