-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyton-version to setup PyPy output #365
Add pyton-version to setup PyPy output #365
Conversation
I think it'll be better to move such kind of logic here. |
Yes, it is done, |
@@ -52,6 +52,7 @@ export async function findPyPyVersion( | |||
core.exportVariable('pythonLocation', pythonLocation); | |||
core.addPath(pythonLocation); | |||
core.addPath(_binDir); | |||
core.setOutput('python-version', 'pypy' + resolvedPyPyVersion.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can add to make sure it doesn't regress again?
* upstream/main: (33 commits) Fix virtual-env toolcache links Updated @actions/cache (actions#382) ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (actions#379) Cache hit output (actions#373) Add pyton-version to setup PyPy output (actions#365) Rework pipenv caching test (actions#375) Update README.md to fix setup-python version in example (actions#368) dist fix (actions#367) Cache on ghes (actions#363) Update dist Use `\n` instead of `os.EOL` Update dist Initialise pyproject.toml Build and format Remove console.log Remove unused file Reduce test matrix Parse values from poetry Release Add more tests ...
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v2.2.2` -> `v4.7.0` | | [canonical/data-platform-workflows](https://togithub.com/canonical/data-platform-workflows) | action | major | `v2` -> `v4` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v4.7.0`](https://togithub.com/actions/setup-python/releases/tag/v4.7.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.6.1...v4.7.0) In scope of this release, the support for reading python version from pyproject.toml was added ([https://github.com/actions/setup-python/pull/669](https://togithub.com/actions/setup-python/pull/669)). ```yaml - name: Setup Python uses: actions/setup-python@v4 with: python-version-file: pyproject.toml ``` ##### Besides, it includes such changes as: - Bump tough-cookie and [@​azure/ms-rest-js](https://togithub.com/azure/ms-rest-js) by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/setup-python/pull/697](https://togithub.com/actions/setup-python/pull/697) - Bump semver from 7.3.8 to 7.5.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/actions/setup-python/pull/692](https://togithub.com/actions/setup-python/pull/692) - Fix typos found by codespell by [@​DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) in [https://github.com/actions/setup-python/pull/650](https://togithub.com/actions/setup-python/pull/650) #### New Contributors - [@​dariocurr](https://togithub.com/dariocurr) made their first contribution in [https://github.com/actions/setup-python/pull/669](https://togithub.com/actions/setup-python/pull/669) - [@​DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) made their first contribution in [https://github.com/actions/setup-python/pull/650](https://togithub.com/actions/setup-python/pull/650) **Full Changelog**: actions/setup-python@v4...v4.7.0 ### [`v4.6.1`](https://togithub.com/actions/setup-python/releases/tag/v4.6.1) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.6.0...v4.6.1) #### What's Changed - Fix `allow-prereleases` sample configuration by [@​mayeut](https://togithub.com/mayeut) in [https://github.com/actions/setup-python/pull/615](https://togithub.com/actions/setup-python/pull/615) - Fix a incorrect link advanced-usage.md by [@​siyuan0322](https://togithub.com/siyuan0322) in [https://github.com/actions/setup-python/pull/657](https://togithub.com/actions/setup-python/pull/657) - Remove implicit dependency by [@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) in [https://github.com/actions/setup-python/pull/668](https://togithub.com/actions/setup-python/pull/668) - Automatic update of configuration files from 05/23/2023 by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/actions/setup-python/pull/671](https://togithub.com/actions/setup-python/pull/671) - Add warning for python 2.7 on release/v4 by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [https://github.com/actions/setup-python/pull/673](https://togithub.com/actions/setup-python/pull/673) #### New Contributors - [@​siyuan0322](https://togithub.com/siyuan0322) made their first contribution in [https://github.com/actions/setup-python/pull/657](https://togithub.com/actions/setup-python/pull/657) - [@​nikolai-laevskii](https://togithub.com/nikolai-laevskii) made their first contribution in [https://github.com/actions/setup-python/pull/668](https://togithub.com/actions/setup-python/pull/668) **Full Changelog**: actions/setup-python@v4...v4.6.1 ### [`v4.6.0`](https://togithub.com/actions/setup-python/releases/tag/v4.6.0): Add allow-prereleases input [Compare Source](https://togithub.com/actions/setup-python/compare/v4.5.0...v4.6.0) In scope of this release we added a new input (`allow-prereleases`) to allow [falling back to pre-release versions of Python when a matching GA version of Python is not available](https://togithub.com/actions/setup-python/pull/414) ```yaml steps: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: python-version: 3.12 allow-prereleases: true ``` Besides, we added such changes as: - Fix bug to trim new line for PyPy version: [https://github.com/actions/setup-python/pull/610](https://togithub.com/actions/setup-python/pull/610) - Added pip dependency file to generate hash from it: [https://github.com/actions/setup-python/pull/604](https://togithub.com/actions/setup-python/pull/604) - Improved error handling for saving and restoring cache: [https://github.com/actions/setup-python/pull/618](https://togithub.com/actions/setup-python/pull/618) - Add warning if cache paths are empty: [https://github.com/actions/setup-python/pull/642](https://togithub.com/actions/setup-python/pull/642) ### [`v4.5.0`](https://togithub.com/actions/setup-python/releases/tag/v4.5.0): Fix cache issue for Poetry projects located in subfolders [Compare Source](https://togithub.com/actions/setup-python/compare/v4.4.0...v4.5.0) In scope of this release we fixed cache issue for Poetry projects located in subfolders ([https://github.com/actions/setup-python/issues/446](https://togithub.com/actions/setup-python/issues/446)). Besides that we updated json5 version from 2.2.0 to 2.2.3 ([https://github.com/actions/setup-python/pull/579](https://togithub.com/actions/setup-python/pull/579)). ### [`v4.4.0`](https://togithub.com/actions/setup-python/releases/tag/v4.4.0): Add support to install multiple python versions [Compare Source](https://togithub.com/actions/setup-python/compare/v4.3.1...v4.4.0) In scope of this release we added support to [install multiple python versions](https://togithub.com/actions/setup-python/pull/567). For this you can try to use this snippet: ```yaml - uses: actions/setup-python@v4 with: python-version: | 3.8 3.9 3.10 ``` Besides, we changed logic with throwing the error for GHES if cache is unavailable to warn ([https://github.com/actions/setup-python/pull/566](https://togithub.com/actions/setup-python/pull/566)). ### [`v4.3.1`](https://togithub.com/actions/setup-python/releases/tag/v4.3.1): Improve error handling and messages [Compare Source](https://togithub.com/actions/setup-python/compare/v4.3.0...v4.3.1) In scope of this release we added improved error message to put operating system and its version in the logs ([https://github.com/actions/setup-python/pull/559](https://togithub.com/actions/setup-python/pull/559)). Besides, the release - fixes issue about [specifying architecture for pypy-nightly on Windows](https://togithub.com/actions/setup-python/issues/518) with related [pull request](https://togithub.com/actions/setup-python/pull/520). - improves error handling for Http Errors ([https://github.com/actions/setup-python/pull/511](https://togithub.com/actions/setup-python/pull/511)). - updates minimatch ([https://github.com/actions/setup-python/pull/558](https://togithub.com/actions/setup-python/pull/558)). ### [`v4.3.0`](https://togithub.com/actions/setup-python/releases/tag/v4.3.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.2.0...v4.3.0) - Update [@​actions/core](https://togithub.com/actions/core) to 1.10.0 version [#​517](https://togithub.com/actions/setup-python/issues/517) - Update [@​actions/cache](https://togithub.com/actions/cache) to 3.0.4 version [#​499](https://togithub.com/actions/setup-python/issues/499) - Only use github.token on github.com [#​443](https://togithub.com/actions/setup-python/issues/443) - Improvement of documentation [#​477](https://togithub.com/actions/setup-python/issues/477) [#​479](https://togithub.com/actions/setup-python/issues/479) [#​491](https://togithub.com/actions/setup-python/issues/491) [#​492](https://togithub.com/actions/setup-python/issues/492) ### [`v4.2.0`](https://togithub.com/actions/setup-python/releases/tag/v4.2.0): Add check-latest input and bug fixes [Compare Source](https://togithub.com/actions/setup-python/compare/v4.1.0...v4.2.0) In scope of this release we add the [check-latest](https://togithub.com/actions/setup-python/pull/406) input. If check-latest is set to true, the action first checks if the cached version is the latest one. If the locally cached version is not the most up-to-date, the version will then be downloaded from [python-versions](https://togithub.com/actions/python-versions) repository. By default check-latest is set to false. For PyPy it will to try to reach https://downloads.python.org/pypy/versions.json ##### Example of usage: ```yaml steps: - uses: actions/checkout@v3 - uses: actions/setup-python@v4 with: python-version: '3.9' check-latest: true - run: python --version ``` Besides, it includes such changes as - Resolved logs for python-version and file inputs: [https://github.com/actions/setup-python/pull/465](https://togithub.com/actions/setup-python/pull/465) - Added linux os release info to primary key: [https://github.com/actions/setup-python/pull/467](https://togithub.com/actions/setup-python/pull/467) - Added fix to change Python versions for poetry: [https://github.com/actions/setup-python/pull/445](https://togithub.com/actions/setup-python/pull/445) - Fix Tool Path handling for self-hosted runners: [https://github.com/actions/setup-python/pull/466](https://togithub.com/actions/setup-python/pull/466) ### [`v4.1.0`](https://togithub.com/actions/setup-python/releases/tag/v4.1.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.0.0...v4.1.0) In scope of this pull request we updated `actions/cache` package as the new version contains fixes for [caching error handling](https://togithub.com/actions/setup-python/pull/448). Moreover, we added a new input [update-environment](https://togithub.com/actions/setup-python/pull/411). This option allows to specify if the action shall update environment variables (default) or not. ##### Update-environment input ```yaml - name: setup-python 3.9 uses: actions/setup-python@v4 with: python-version: 3.9 update-environment: false ``` **Besides, we added such changes as:** - Allow python-version-file to be a relative path: [https://github.com/actions/setup-python/pull/431](https://togithub.com/actions/setup-python/pull/431) - Added new environment variables for `Cmake`: [https://github.com/actions/setup-python/pull/440](https://togithub.com/actions/setup-python/pull/440) - Updated error message for resolveVersion: [https://github.com/actions/setup-python/pull/450](https://togithub.com/actions/setup-python/pull/450) - Assign default value of `AGENT_TOOLSDIRECTORY` if not set: [https://github.com/actions/setup-python/pull/394](https://togithub.com/actions/setup-python/pull/394) ### [`v4.0.0`](https://togithub.com/actions/setup-python/releases/tag/v4.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v3.1.4...v4.0.0) ##### What's Changed - Support for `python-version-file` input: [#​336](https://togithub.com/actions/setup-python/issues/336) Example of usage: ```yaml - uses: actions/setup-python@v4 with: python-version-file: '.python-version' # Read python version from a file - run: python my_script.py ``` There is no default python version for this `setup-python` major version, the action requires to specify either `python-version` input or `python-version-file` input. If the `python-version` input is not specified the action will try to read required version from file from `python-version-file` input. - Use pypyX.Y for PyPy `python-version` input: [#​349](https://togithub.com/actions/setup-python/issues/349) Example of usage: ```yaml - uses: actions/setup-python@v4 with: python-version: 'pypy3.9' # pypy-X.Y kept for backward compatibility - run: python my_script.py ``` - `RUNNER_TOOL_CACHE` environment variable is equal `AGENT_TOOLSDIRECTORY`: [#​338](https://togithub.com/actions/setup-python/issues/338) - Bugfix: create missing `pypyX.Y` symlinks: [#​347](https://togithub.com/actions/setup-python/issues/347) - `PKG_CONFIG_PATH` environment variable: [#​400](https://togithub.com/actions/setup-python/issues/400) - Added `python-path` output: [#​405](https://togithub.com/actions/setup-python/issues/405) `python-path` output contains Python executable path. - Updated `zeit/ncc` to `vercel/ncc` package: [#​393](https://togithub.com/actions/setup-python/issues/393) - Bugfix: fixed output for prerelease version of poetry: [#​409](https://togithub.com/actions/setup-python/issues/409) - Made `pythonLocation` environment variable consistent for Python and PyPy: [#​418](https://togithub.com/actions/setup-python/issues/418) - Bugfix for `3.x-dev` syntax: [#​417](https://togithub.com/actions/setup-python/issues/417) - Other improvements: [#​318](https://togithub.com/actions/setup-python/issues/318) [#​396](https://togithub.com/actions/setup-python/issues/396) [#​384](https://togithub.com/actions/setup-python/issues/384) [#​387](https://togithub.com/actions/setup-python/issues/387) [#​388](https://togithub.com/actions/setup-python/issues/388) ### [`v3.1.4`](https://togithub.com/actions/setup-python/releases/tag/v3.1.4) [Compare Source](https://togithub.com/actions/setup-python/compare/v3.1.3...v3.1.4) #### What's Changed In the scope of this patch release, the warning for deprecating Python 2.x was added in [https://github.com/actions/setup-python/pull/674](https://togithub.com/actions/setup-python/pull/674) by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) For more information, check out [https://github.com/actions/setup-python/issues/672](https://togithub.com/actions/setup-python/issues/672) **Full Changelog**: actions/setup-python@v3...v3.1.4 ### [`v3.1.3`](https://togithub.com/actions/setup-python/releases/tag/v3.1.3): Update actions/core to 1.10.0 for v3 [Compare Source](https://togithub.com/actions/setup-python/compare/v3.1.2...v3.1.3) In scope of this release we update actions/core to 1.10.0 for v3 major tag: [https://github.com/actions/setup-python/pull/624](https://togithub.com/actions/setup-python/pull/624) ### [`v3.1.2`](https://togithub.com/actions/setup-python/releases/tag/v3.1.2): Update actions/cache version to 2.0.2 [Compare Source](https://togithub.com/actions/setup-python/compare/v3.1.1...v3.1.2) In scope of this release we updated `actions/cache` package as the new version contains fixes related to GHES 3.5 ([https://github.com/actions/setup-python/pull/382](https://togithub.com/actions/setup-python/pull/382)) ### [`v3.1.1`](https://togithub.com/actions/setup-python/releases/tag/v3.1.1): Add "cache-hit" output and fix "python-version" output for PyPy [Compare Source](https://togithub.com/actions/setup-python/compare/v3.1.0...v3.1.1) This release introduces new output cache-hit ([https://github.com/actions/setup-python/pull/373](https://togithub.com/actions/setup-python/pull/373)) and fix python-version output for PyPy ([https://github.com/actions/setup-python/pull/365](https://togithub.com/actions/setup-python/pull/365)) The cache-hit output contains boolean value indicating that an exact match was found for the key. It shows that the action uses already existing cache or not. The output is available only if cache is enabled. The python-version contains version of Python or PyPy. ### [`v3.1.0`](https://togithub.com/actions/setup-python/releases/tag/v3.1.0): Support caching poetry dependencies and caching on GHES 3.5 [Compare Source](https://togithub.com/actions/setup-python/compare/v3.0.0...v3.1.0) - In the scope of this release, we added [support for caching from GHES 3.5](https://togithub.com/actions/setup-python/issues/362) and fixed the download issue for files > 2GB during restore. - Caching poetry dependencies ```yaml steps: - uses: actions/checkout@v3 - name: Install poetry run: pipx install poetry - uses: actions/setup-python@v3 with: python-version: '3.9' cache: 'poetry' - run: poetry install - run: poetry run pytest ``` ### [`v3.0.0`](https://togithub.com/actions/setup-python/releases/tag/v3.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v2.3.4...v3.0.0) #### What's Changed - Update default runtime to node16 ([https://github.com/actions/setup-python/pull/340](https://togithub.com/actions/setup-python/pull/340)) - Update `package-lock.json` file version to 2, `@types/node` to 16.11.25 and `typescript` to 4.2.3 ([https://github.com/actions/setup-python/pull/341](https://togithub.com/actions/setup-python/pull/341)) - Remove legacy `pypy2` and `pypy3` keywords ([https://github.com/actions/setup-python/pull/342](https://togithub.com/actions/setup-python/pull/342)) ##### Breaking Changes With the update to Node 16, all scripts will now be run with Node 16 rather than Node 12. This new major release removes support of legacy `pypy2` and `pypy3` keywords. Please use more specific and flexible syntax to specify a PyPy version: ```yaml jobs: build: runs-on: ubuntu-latest strategy: matrix: python-version: - 'pypy-2.7' # the latest available version of PyPy that supports Python 2.7 - 'pypy-3.8' # the latest available version of PyPy that supports Python 3.8 - 'pypy-3.8-v7.3.8' # Python 3.8 and PyPy 7.3.8 steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }} ``` See more usage examples in the [documentation](https://togithub.com/actions/setup-python#specifying-a-pypy-version) ### [`v2.3.4`](https://togithub.com/actions/setup-python/releases/tag/v2.3.4) [Compare Source](https://togithub.com/actions/setup-python/compare/v2.3.3...v2.3.4) #### What's Changed In the scope of this patch release, the warning for deprecating Python 2.x was added in [https://github.com/actions/setup-python/pull/675](https://togithub.com/actions/setup-python/pull/675) by [@​dmitry-shibanov](https://togithub.com/dmitry-shibanov) For more information, check out [https://github.com/actions/setup-python/issues/672](https://togithub.com/actions/setup-python/issues/672) **Full Changelog**: actions/setup-python@v2...v2.3.4 ### [`v2.3.3`](https://togithub.com/actions/setup-python/releases/tag/v2.3.3): Update actions/core to 1.10.0 for v2 [Compare Source](https://togithub.com/actions/setup-python/compare/v2.3.2...v2.3.3) In scope of this release we update actions/core to 1.10.0 for v2 major tag: [https://github.com/actions/setup-python/pull/533](https://togithub.com/actions/setup-python/pull/533). ### [`v2.3.2`](https://togithub.com/actions/setup-python/releases/tag/v2.3.2): Update primary and restore keys for pip [Compare Source](https://togithub.com/actions/setup-python/compare/v2.3.1...v2.3.2) In scope of this release we [include a version of python in restore and primary cache keys for pip](https://togithub.com/actions/setup-python/pull/303). Besides, we add temporary fix for Windows caching [issue](https://togithub.com/actions/setup-python/pull/332), that the `pip cache dir` command returns non zero exit code or writes to stderr. Moreover we updated [node-fetch dependency](https://togithub.com/actions/setup-python/pull/327). ### [`v2.3.1`](https://togithub.com/actions/setup-python/releases/tag/v2.3.1): Update actions/cache version to 1.0.8 [Compare Source](https://togithub.com/actions/setup-python/compare/v2.3.0...v2.3.1) We have updated [actions/cache](https://togithub.com/actions/toolkit/blob/main/packages/cache/RELEASES.md#108) dependency version to 1.0.8 to support 10GB cache upload ### [`v2.3.0`](https://togithub.com/actions/setup-python/releases/tag/v2.3.0): Support caching dependencies [Compare Source](https://togithub.com/actions/setup-python/compare/v2.2.2...v2.3.0) This release introduces dependency caching support ([https://github.com/actions/setup-python/pull/266](https://togithub.com/actions/setup-python/pull/266)) #### Caching dependencies. The action has a built-in functionality for caching and restoring pip/pipenv dependencies. The `cache` input is optional, and caching is turned off by default. Besides, this release introduces dependency caching support for mono repos and repositories with complex structure. By default, the action searches for the dependency file (requirements.txt for pip or Pipfile.lock for pipenv) in the whole repository. Use the `cache-dependency-path` input for cases when you want to override current behaviour and use different file for hash generation (for example requirements-dev.txt). This input supports wildcards or a list of file names for caching multiple dependencies. ##### Caching pip dependencies: steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pip' - run: pip install -r requirements.txt - run: pip test ##### Caching pipenv dependencies: steps: - uses: actions/checkout@v2 - name: Install pipenv run: pipx install pipenv - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pipenv' - run: pipenv install - run: pipenv test ##### Change dependency file: steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v2 with: python-version: '3.9' cache: 'pip' cache-dependency-path: '**/requirements-dev.txt' - run: pip install -r subdirectory/requirements-dev.txt - run: pip test </details> <details> <summary>canonical/data-platform-workflows (canonical/data-platform-workflows)</summary> ### [`v4`](https://togithub.com/canonical/data-platform-workflows/compare/v3...v4) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v3...v4) ### [`v3`](https://togithub.com/canonical/data-platform-workflows/compare/v2...v3) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v2...v3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 2am on saturday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/spark-k8s-toolkit-py). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Description:
During the migration from the legacy PyPy input the setting output "pyton-version" was omitted
Related issue:
link to the related issue
Test build
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true
confirmation the output is set:
https://github.com/akv-demo/setup-python-test/runs/5765771141?check_suite_focus=true#step:4:39
Check list: