make polyamorous a separate gem #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me
…Sent from my iPhone
On 10 Feb 2019, at 13:15, Greg Molnar ***@***.***> wrote:
Let's release polyamorous as a separate gem, as discussed in here: rzane/baby_squeel#97
@rzane once this is merged I will release a new version of polyamorous with support for >= Active Record 5
/cc @seanfcarroll
You can view, comment on, or merge this pull request online at:
#1002
Commit Summary
make polyamorous a separate gem
File Changes
M lib/ransack.rb (1)
R polyamorous/lib/polyamorous.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.0_ruby_2/join_association.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.0_ruby_2/join_dependency.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.1_ruby_2/join_association.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.1_ruby_2/join_dependency.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.2.0_ruby_2/join_association.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.2.0_ruby_2/join_dependency.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.2.1_ruby_2/join_association.rb (0)
R polyamorous/lib/polyamorous/activerecord_5.2.1_ruby_2/join_dependency.rb (0)
R polyamorous/lib/polyamorous/join.rb (0)
R polyamorous/lib/polyamorous/swapping_reflection_class.rb (0)
R polyamorous/lib/polyamorous/tree_node.rb (0)
A polyamorous/lib/polyamorous/version.rb (3)
A polyamorous/polyamorous.gemspec (37)
A polyamorous/spec/blueprints/articles.rb (5)
A polyamorous/spec/blueprints/comments.rb (5)
A polyamorous/spec/blueprints/notes.rb (3)
A polyamorous/spec/blueprints/people.rb (4)
A polyamorous/spec/blueprints/tags.rb (3)
A polyamorous/spec/helpers/polyamorous_helper.rb (26)
A polyamorous/spec/polyamorous/join_association_spec.rb (29)
A polyamorous/spec/polyamorous/join_dependency_spec.rb (93)
A polyamorous/spec/polyamorous/join_spec.rb (19)
A polyamorous/spec/spec_helper.rb (43)
A polyamorous/spec/support/schema.rb (98)
M ransack.gemspec (1)
Patch Links:
https://github.com/activerecord-hackery/ransack/pull/1002.patch
https://github.com/activerecord-hackery/ransack/pull/1002.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hi @gregmolnar! Thanks for doing this. Any idea when you'll be able to release a new version of polyamorous? |
|
@brentdodell I want to get this issue sorted before that: #1004 |
|
Thanks @gregmolnar! |
This was referenced Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's release polyamorous as a separate gem, as discussed in here: rzane/baby_squeel#97
@rzane once this is merged I will release a new version of polyamorous with support for >= Active Record 5
/cc @seanfcarroll