Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs #963

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Conversation

tommaso1
Copy link
Contributor

I'm a beginner in rails, and I am used to be a mobile developer. I'm submitting this pull request because i found not so clear how to construct the symbol argument of search_field. I had to read all the wiki and it took me an hour to understand how predicates combines together. I think it would be useful for beginners having on the main readme a little more formal explanation about the syntax. The content of the pr is what i figured out and it may be incomplete or wrong, but definitely it would be useful to have something like that on the read me so users can use this wonderful gem more easily!

[skip-ci] Few more lines about the syntax of predicates
@scarroll32
Copy link
Member

Looks good. Thanks for your contribution @tommaso1

@gregmolnar gregmolnar merged commit c36d8b6 into activerecord-hackery:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants