Expose is_set #99
Merged
Expose is_set #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonathas-Conceicao
requested changes
Feb 22, 2020
robjtede
approved these changes
Feb 25, 2020
|
@Jonathas-Conceicao On some repositories (actix, actix-net, actix-web), merge should be done with care. And I didn't review this yet... |
|
@JohnTitor not sure what I did wrong here. But I will start to wait on your review before merging in the future. |
|
@Jonathas-Conceicao Don't have to wait though, but you could ping me when API is changed, it'd be great! Otherwise, I may miss the change :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a situation I need check if there's a currently running actix system, but not panic when there isn't. This pub crate function just works and seems not dangerous to expose it.