Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SameSite value "None" cookie attribute #1035

Closed
ghost opened this issue Aug 14, 2019 · 1 comment · Fixed by #1282
Closed

Support SameSite value "None" cookie attribute #1035

ghost opened this issue Aug 14, 2019 · 1 comment · Fixed by #1282
Labels
C-improvement Category: an improvement to existing functionality needs-investigation

Comments

@ghost
Copy link

ghost commented Aug 14, 2019

We should set the cookie attribute “SameSite = None” for Chrome browser.

refs:
@fafhrd91
Copy link
Member

There is no such functionality, PR is required

robjtede pushed a commit that referenced this issue Jan 16, 2020
@kfrob
allow explicit SameSite=None cookies
1edf074 
fixes #1035
@robjtede robjtede mentioned this issue Jan 16, 2020
Merged
robjtede added a commit that referenced this issue Jan 16, 2020
@robjtede
allow explicit SameSite=None cookies
3f1600f 
fixes #1035
robjtede added a commit that referenced this issue Jan 16, 2020
@robjtede
allow explicit SameSite=None cookies
fb2c36a 
fixes #1035
robjtede added a commit that referenced this issue Jan 16, 2020
@robjtede
allow explicit SameSite=None cookies
59509d5 
fixes #1035
robjtede added a commit that referenced this issue Jan 16, 2020
@robjtede
allow explicit SameSite=None cookies
464db0c 
fixes #1035
@robjtede robjtede added the C-improvement Category: an improvement to existing functionality label Jan 20, 2020
robjtede added a commit that referenced this issue Jan 21, 2020
@robjtede
allow explicit SameSite=None cookies
315dbf1 
fixes #1035
robjtede added a commit that referenced this issue Jan 22, 2020
@robjtede
allow explicit SameSite=None cookies
8182fa0 
fixes #1035
JohnTitor pushed a commit that referenced this issue Jan 23, 2020
@robjtede @JohnTitor
allow explicit SameSite=None cookies (#1282)
a328794 
fixes #1035
theikkila pushed a commit to theikkila/actix-web that referenced this issue Feb 7, 2020
@robjtede @theikkila
allow explicit SameSite=None cookies (actix#1282)
551b56b 
fixes actix#1035
(cherry picked from commit a328794)
@theikkila theikkila mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-improvement Category: an improvement to existing functionality needs-investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow explicit SameSite=None cookies actix/actix-web
3 participants
@leizzer @fafhrd91 @robjtede