make matrix mode better defined, pull in Color/Wheel helper functions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make matrix mode better defined by defining the strand length to be equivalentl to a 1xN matrix. Allow the matrix sizes to be updated. Pull in the Color and Wheel helper functions from the examples as stati functions.
Make matrix mode better defined by defining the strand length to be equivalentl to a 1xN matrix. Allow the matrix sizes to be updated. Allow switching back and forth between treating the pixels as a single strand OR as a matrix. Pull in the Color and Wheel helper functions from the examples as stati functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating a pull request to contribute to Adafruit's GitHub code!
Before you open the request please review the following guidelines and tips to
help it be more easily integrated:
of the code were modified. This will help us understand any risks of integrating
the code.
Make matrix mode better defined by defining the strand length to be equivalentl to a 1xN matrix.
Allow the matrix sizes to be updated.
Allow switching back and forth between treating the pixels as a single strand OR as a matrix.
Pull in the Color and Wheel helper functions from the examples as stati functions.
In the example code, take advantage of helper functions now being in the Adafruit_WS2801 library.
doesn't apply to a supported platform of the library please mention it.
None: fully generic changes
strive to not break users of the code and running tests/examples helps with this
process.
I am running code against this changed code. For example, I have a program file that incorporates both of the example code, switching back and forth between using the code in strand mode and in matrix mode.
Thank you again for contributing! We will try to test and integrate the change
as soon as we can, but be aware we have many GitHub repositories to manage and
can't immediately respond to every request. There is no need to bump or check in
on a pull request (it will clutter the discussion of the request).
Also don't be worried if the request is closed or not integrated--sometimes the
priorities of Adafruit's GitHub code (education, ease of use) might not match the
priorities of the pull request. Don't fret, the open source community thrives on
forks and GitHub makes it easy to keep your changes in a forked repo.
After reviewing the guidelines above you can delete this text from the pull request.