added Fujitsu MB85RS4MT FRAM; added sleep mode #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathach
reviewed
Jul 18, 2024
Adafruit_FRAM_SPI.cpp
Outdated
| spi_dev->endTransactionWithDeassertingCS(); | ||
| delayMicroseconds(100); | ||
|
|
||
| return spi_dev->write(&cmd, 1); |
There was a problem hiding this comment.
we don't really need to do spi write() here, cs along should be able to put chip out of sleep
- check if sleep mode is supported by device
hathach
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
thank you for your PR, I made some changes
- add pre-commit and fix clang (quite some bit of format changes)
- rename API to enterSleep() and exitSleep()
- remove spi write in exitSleep()
- check if device support sleep mode before executing the command.
Please try it again to see if this still works for you.
|
Hello Ha Thach, Thanks for merging my pull request. I've checked my application https://github.com/FUEL4EP/HomeAutomation/tree/master/AsksinPP_developments/sketches/HB-UNI-Sensor1-THP_MA-AHT20_BMP280 with your library commit 928281f. Everything is running smoothly as expected. In sleep mode, the current is again about 12 uA. |
|
great thank you for your updated feed back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes of this pull request are:
The changes have been successfully verified with my PCB HB-UNI-SEN-BATT_ATMega1284P_E07-868MS10_FRAM_FUEL4EP.
In sleep mode, the current dissipation has been reduced from 30 uA (without sleep mode) to 12 uA (with sleep mode).