Allow user to specify which SPI port to use. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the same changes I made for the MAX31855 library, for a different PJRC forum member. So far I have tested that it builds. Earlier today I suggested the changes to a different user and they made the changes and it worked for them. More details on the thread: https://forum.pjrc.com/threads/62418-second-spi-channel-teensy-4-1?p=275900&viewfull=1#post275900
|
yeah it would be great ;) we have hundreds of libraries, all written to the standards of the time. we make sure all new libraries in the last few years can use any Wire/SPI but there are many many libraries in the Before Times. so when we do a library support sweep we'll also update it to use BusIO at the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same changes I made for the MAX31855 library, for a different PJRC forum member.
So far I have tested that it builds.
Earlier today I suggested the changes to a different user and they made the changes and it worked for them.
More details on the thread: https://forum.pjrc.com/threads/62418-second-spi-channel-teensy-4-1?p=275900&viewfull=1#post275900
It would be great if someone would make a pass through all of your libraries that are based on your spi_dev object and
would verify that users can use the alternate spi ports