Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board: add support for seeed xiao esp32s3 #329

Merged
merged 3 commits into from
Jun 28, 2023
Merged

board: add support for seeed xiao esp32s3 #329

merged 3 commits into from
Jun 28, 2023

Conversation

LynnL4
Copy link
Contributor

@LynnL4 LynnL4 commented Jun 27, 2023

Checklist

  • Please provide specific title of the PR describing the change
  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
    • Add your board to action ci in correct workflow and alphabet order for release binary
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

hathach
hathach requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR, please address question in the reviews

.github/workflows/build_esp32.yml Outdated Show resolved Hide resolved
ports/espressif/README.md Show resolved Hide resolved
ports/espressif/boards/seeed_xiao_esp32s3/board.h Outdated
//--------------------------------------------------------------------+

#define USB_VID 0x2886
#define USB_PID 0x0056
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide link to the allocated vid/pid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, seeed has own VID 0x2886
https://devicehunt.com/search/type/usb/vendor/2886/device/any

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, but did they allocate the vid 0x0056 for this board as tinyuf2 bootloader ?

Copy link
Contributor Author

@LynnL4 LynnL4 Jun 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PID is assigned internally. As usual, I have configured the bootloader PID as 0x80XX and the APP PID as 0x00XX.
https://github.com/espressif/arduino-esp32/blob/72c41d09538663ebef80d29eb986cd5bc3395c2d/variants/XIAO_ESP32S3/pins_arduino.h#L8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks for clarification, all is good

hathach
hathach approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you.

@hathach hathach merged commit f8df389 into adafruit:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LynnL4 @hathach