-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghostfat test boards #94
Conversation
Collapsing to reduce thread length
@hathach -- Can you help with two things?
Compilation:On my Ubuntu system, to make the test ports compile requires removing two options from Lines 136 to 137 in 54cff8b
Line 12 in 54cff8b
|
no problems at all, leave that to me. I just resolved the conflict with master and push the update. Give me a bit of time to go through the code. I think I could setup unit tests with CMock/Unity using your tests. That would be easier to run on ci and a bit cleaner look for the ports. Will post more update. Update: I just realized this is 6 days ago, hmm, the collapsible probably have me miss your message earlier 🤕 |
@hathach -- Yes, it was a few days back. Since then, I got it to work with CI. So, you can merge as-is, no work, and get GhostFAT validation. |
OK, this is ready for review. See success in checks from commit deae8ca ... listing the four GhostFAT code compiling, comparing against known-good images, and even ignoring the two very narrow exceptions required. Two exceptions detailed
Two variations allowed from the known good file system:
The code allows very narrow exceptions with multiple checks, to allow these two differences, without allowing other regressions to fall through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant !! Thank you very much for your effort and time put into this PR. Though I still think we should separate the native build from current build system for unit test cmock/unity. I will merge this now and make a follow up PR to decouple the native build. Thank you very much for your awesome work !!!!
Sorry, please ignore this "review request" ... accidental click. |
no problem at all :) |
The goal of this branch is to enable, as part of the normal build process, validation of GhostFat image generation.
test_main()
function, using existing codetest_main()
test_main()
test_main()
NOTE: When the ghostfat image that is generated would need to change, such as for a bugfix, then updated versions of the known-good file system images would also need to also be committed.