Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Fix #176: Ensure that the local cache is reset if the remote cache is cleared #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickwilliams-eventbrite

Per #176, we need to make sure that the local cache gets reset if the remote cache is cleared. This pull request accomplishes that.

…e cache is cleared

Per adamchainz#176, we need to make sure that the local cache gets reset if the remote cache is cleared. This commit accomplishes that.
@nickwilliams-eventbrite
Copy link
Author

nickwilliams-eventbrite commented May 7, 2019

[bump] Could I get some 👀 on this pull request, please? Thanks!

@nickwilliams-eventbrite
Copy link
Author

@adamchainz, any thoughts on this really simple pull request?

@adamchainz
Copy link
Owner

Hi Nick

Somehow this is the first notification that got through. I didn't get emails for you opening the PR or your first "bump". I checked my email history, this is literally the first one that got through 🤷‍♂️

Since version 2.0.3 on 2019-05-17 I decided not to maintain the library because I have too much going on: https://github.com/adamchainz/django-modeldict/blob/master/HISTORY.rst . I have one partial offer around taking over maintenance but it hasn't really gone anywhere yet.

If your PR was really simple I'd do it, but there's a lot to understand in some complex code that I've not looked at in years. I appreciate your thoroughness in describing the issue but I don't have time to understand it all. Maybe if there was a test I'd take and release it but that would still leave it unmaintained.

If you're interested in maintenance yourself please contact me over email, or you could always fork and release as django-modeldict-mycompany and I'd happily add a PR with a header saying you're maintaining it there.

Thanks,

Adam

@nickwilliams-eventbrite
Copy link
Author

Oh. I saw a bunch of commits since January and assumed you were still maintaining it. The pull request is only 3 lines of (added) code (no deletions). But if you've retired the project and aren't going to release it any more, there's not really any point in merging this, I suppose. We'll just continue using the monkey patch for now as we work on migrating away from Gargoyle and on to some other project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants