This repository has been archived by the owner on May 11, 2021. It is now read-only.
Fix missed remote cache updates #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about slow review, thanks very much for this! Merged in dc8ea28 . |
|
And released on PyPI at 1.5.2: https://pypi.python.org/pypi/django-modeldict-yplan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This extends #20 by fixing a few extra issues that where causing web server processes to usually miss cache updates while processing several requests per second (see https://github.com/YPlan/gargoyle/issues/83). The fixed issues are:
CachedDict._local_last_updatedbeing set even if local_cache was not updated (similar to Improve calculation of local cache expiration #20), which may affect calculation ofCachedDict.local_cache_is_invalid().CachedDict.local_cache_is_invalid()would return a false negative if remote cache is updated within the same second asCachedDict._local_last_updated, due to time being rounded asint(). The chances of this were made bigger by the previous issue together with therequest_finishedhandler constantly expiring the local cache.modelvariable inCachedDict.__repr__().