Adds improved matching for globs #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…watchfiles into full_match-support
for more information, see https://pre-commit.ci
…watchfiles into full_match-support
for more information, see https://pre-commit.ci
|
How we feelin' about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the matching mechanism for globs addressed in PR #92
This problem is solved with the new
full_matchmethod available in python 3.13. https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.full_matchTo make the problem less severe in previous python versions, I made an improved version of
fnmatch()that handles the most common*/**pattern. (Using onlyfnmatch()does not select files on the top level making things feel very broken.) This way we can get the benefit of improved matching in older versions, without having to rely on an additionalglobberdependency.Fixes:
#69
#91