Add read-only support for Dmg archives #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Thanks! I have a Mac. I need to figure out how to make a dmg with test data |
|
Maybe I'm not making a valid DMG but AFPS isn't supported and HFS reports no entries: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests, this adds support for reading and extracting Dmg archives.
Only Dmg archives that use the GPT partitioning scheme with a HFS+ or HFSX data partition are supported, but that should cover the large majority of Dmgs out there (any DMGs created on MacOS 8.1 and newer will have this format).
I didn't see any way of implementing this as read-through so only the archive API is available.
Unfortunately I'm not able to provide test data as I don't have access to a Mac to create Dmgs. I have tested extensively using my own data but I cannot share that data publicly. Hopefully someone else will be kind enough to provide those.