Fix skywrath mage error when rooted / ancient seal when retreating #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When considering ancient seal during retreat, the range calculation was wrong, and had a negative range unless movement speed was 0. When this happened (e.g. when rooted), it returned all nearby enemies instead of one target, causing an error (and preventing any ability use). These have been fixed so now skywrath will cast ancient seal at the most dangerous enemy when retreating. Moved GetMostDangerousEnemy to a separate function since it is used in two places. Added comments with ability names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a. When considering ancient seal during retreat, the range calculation was wrong, and had a negative range unless movement speed was 0.
b. When this happened (e.g. when rooted), it returned all nearby enemies instead of one target, causing an error (and preventing any ability use).