Improve pudge hook #109
Merged
Improve pudge hook #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix for search radius: use bounding box of interfering unit rather than target when calculating collisions Fix ally saving calculation; would always result in error previously Note: with recent fix for Remove(), pudge uses hook less, because he can (mostly) tell things are in the way
ArcherWayne
approved these changes
Jun 29, 2023
adamqqqplay
reviewed
Jun 29, 2023
ability_item_usage_pudge.lua
Outdated
| local ally = AbilityExtensions:GetNearbyNonIllusionHeroes(npcBot, range, false, BOT_MODE_NONE):Filter(allies | ||
| , function(t) | ||
| local ally = AbilityExtensions:GetNearbyNonIllusionHeroes(npcBot, range, false, BOT_MODE_NONE): | ||
| Filter(function(t) | ||
| return t:IsStunned() or t:IsRooted() |
There was a problem hiding this comment.
Does this line need an extra indent?
There was a problem hiding this comment.
Yeah, I think an indent is more correct. Changed.
adamqqqplay
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: a fix for Remove() in a separate commit/PR causes pudge to use hook less, because he can (mostly) tell things are in the way.