Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for React 18 #2459

Merged
merged 37 commits into from
Apr 7, 2022
Merged

Add support for React 18 #2459

merged 37 commits into from
Apr 7, 2022

Conversation

nstepien
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #2459 (87362b4) into main (2b402e8) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   96.23%   96.15%   -0.09%     
==========================================
  Files          38       38              
  Lines        1247     1247              
  Branches      393      393              
==========================================
- Hits         1200     1199       -1     
- Misses         47       48       +1     
Impacted Files Coverage Δ
src/DataGrid.tsx 94.23% <0.00%> (-0.21%) ⬇️

@nstepien
Copy link
Contributor Author

nstepien commented Mar 29, 2022

Before we go forward with this:

@amanmahajan7
Copy link
Contributor

amanmahajan7 commented Mar 29, 2022

should we drop support for React 16/17? We don't have the capacity to support them.

We may be able to support as we are not using any react 18 features yet

@nstepien nstepien marked this pull request as ready for review April 6, 2022 23:35
@nstepien nstepien requested a review from amanmahajan7 as a code owner April 6, 2022 23:35
@nstepien
Copy link
Contributor Author

nstepien commented Apr 6, 2022

Seeing as we already have types for createRoot when imported from react-dom/client, let's go forward with this.

@nstepien
Copy link
Contributor Author

nstepien commented Apr 6, 2022

We have +1 missed line in the coverage for some reason. Do we have a test for this specific line?
https://app.codecov.io/gh/adazzle/react-data-grid/compare/2459/changes
image

@nstepien nstepien enabled auto-merge (squash) April 7, 2022 14:56
@nstepien nstepien merged commit 4a57ce2 into main Apr 7, 2022
@nstepien nstepien deleted the react18 branch April 7, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants