Discussion on adlast.adl #121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion piece on adlast that exposes the names of primitives as union branches and also limits scope of `TypeExpr` type params to zero, one or many. I think in terms of a short term route to connect different tooling it might be better instead to open the existing tooling to importing the existing adlast json instead of this half-old-half new variant above.
Omit whitespace edits
Omit whitespace edits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion edits on adlast.adl that exposes the names of primitives as union branches and also limits scope of
TypeExprtype params to zero, one or many depending on case.I think in terms of a short term route to connect different tooling it might be better instead to open the existing tooling to importing the existing adlast json instead of this half-old-half-new variant above.