add bearer token check #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanrahic
requested changes
Dec 21, 2020
There was a problem hiding this comment.
Thanks for adding this PR. Check my suggestions. We should try to keep the if (!token) check in line 26. Also, check line 24, if you are setting the token in an if-else statement, make sure to use a mutable variable with let because using const inside of an if-else will limit the scope of that variable to that if-else block.
Comment on lines
+26
to
+29
| if(event.authorizationToken.split(' ')[0] == 'bearer') | ||
| const token = event.authorizationToken.split(' ')[1] // for bearer token | ||
| else | ||
| const token = event.authorizationToken |
There was a problem hiding this comment.
Suggested change
| if(event.authorizationToken.split(' ')[0] == 'bearer') | |
| const token = event.authorizationToken.split(' ')[1] // for bearer token | |
| else | |
| const token = event.authorizationToken | |
| if(event.authorizationToken.split(' ')[0] == 'bearer') | |
| token = event.authorizationToken.split(' ')[1] // for bearer token | |
| else | |
| token = event.authorizationToken | |
| if (!token) | |
| return callback(null, 'Unauthorized') |
| @@ -23,8 +23,10 @@ module.exports.auth = (event, context, callback) => { | |||
| // check header or url parameters or post parameters for token | |||
| const token = event.authorizationToken; | |||
There was a problem hiding this comment.
Suggested change
| const token = event.authorizationToken; | |
| let token |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.