Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embed] Allow to configure some more YouTube parameters #1288

Closed
kwin opened this issue Nov 30, 2020 · 0 comments
Closed

[Embed] Allow to configure some more YouTube parameters #1288

kwin opened this issue Nov 30, 2020 · 0 comments
Labels
enhancement New feature, or improvement to an existing feature.
Milestone
2.14.0

Comments

@kwin
Copy link
Contributor

kwin commented Nov 30, 2020 •
edited
Loading

Feature Request

For the YouTube functionality of the Embed component it would be useful to allow configuration of the following YouTube player parameters

  1. autoplay
  2. loop
  3. playsinline
  4. rel
  5. mute

All of those are boolean parameters.

These parameters should be enabled in general and have their default values defined in the content policies (exposed via the design dialog). If nothing is enabled, those parameters are not set (for keeping backwards-compatibility)

In addition the hl parameter should be automatically set based on the page's language (https://helpx.adobe.com/experience-manager/6-5/sites/developing/using/reference-materials/javadoc/com/day/cq/wcm/api/Page.html#getLanguage--)

Documentation
The edit dialog will contain a checkbox item for each enabled YouTube parameter
The design dialog will contain both a checkbox (for enabling) and a drop-down (for selecting the default value) for each YouTube parameter.
@msagolj msagolj added the enhancement New feature, or improvement to an existing feature. label Nov 30, 2020
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Dec 3, 2020
@kwin
Enable configuration of YouTube Player parameters
af32be5 
All parameters are opt-in, i.e. need to be enabled via content policies.
Their default values can be given via content policies as well.
The parameters are documented in
https://developers.google.com/youtube/player_parameters#Parameters
This closes adobe#1288
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Dec 3, 2020
@kwin
Enable configuration of YouTube Player parameters
2bbfc19 
All parameters are opt-in, i.e. need to be enabled via content policies.
Their default values can be given via content policies as well.
The parameters are documented in
https://developers.google.com/youtube/player_parameters#Parameters
This closes adobe#1288
@kwin kwin mentioned this issue Dec 3, 2020
Merged
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Dec 3, 2020
@kwin
Enable configuration of YouTube Player parameters
a3917de 
All parameters are opt-in, i.e. need to be enabled via content policies.
Their default values can be given via content policies as well.
The parameters are documented in
https://developers.google.com/youtube/player_parameters#Parameters
This closes adobe#1288
kwin added a commit to kwin/aem-core-wcm-components that referenced this issue Jan 14, 2021
@kwin
Enable configuration of YouTube Player parameters
1b64f13 
All parameters are opt-in, i.e. need to be enabled via content policies.
Their default values can be given via content policies as well.
The parameters are documented in
https://developers.google.com/youtube/player_parameters#Parameters
This closes adobe#1288
@msagolj msagolj closed this as completed Jan 27, 2021
@bpauli bpauli added this to the 2.14.0 milestone Jan 29, 2021
@bpauli bpauli changed the title Embed component: Allow to configure some more YouTube parameters [Embed] Allow to configure some more YouTube parameters Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
2.14.0
Development

No branches or pull requests
3 participants
@kwin @bpauli @msagolj