Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinkHandling] Version 2.16.0 automatic path/URL mapping is backwards incompatible with existing mapping configuration of wknd.site #1534

Closed
vladbailescu opened this issue Apr 26, 2021 · 1 comment · Fixed by #1535
Closed

[LinkHandling] Version 2.16.0 automatic path/URL mapping is backwards incompatible with existing mapping configuration of wknd.site #1534

vladbailescu opened this issue Apr 26, 2021 · 1 comment · Fixed by #1535
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Milestone
2.16.2

Comments

@vladbailescu
Copy link
Member

The changes introduced with #713 automatically map all paths/URLs. This is incompatible with mappings like adobe/aem-guides-wknd@8693f94 - URLs get rewritten with /content/wknd removed which causes the link checker to remove them (they're seen as invalid).
@vladbailescu vladbailescu added the bug Unexpected problem or unintended behavior that impairs normal functioning of the product. label Apr 26, 2021
@vladbailescu vladbailescu added this to the 2.16.2 milestone Apr 26, 2021
vladbailescu added a commit that referenced this issue Apr 26, 2021
@vladbailescu
[LinkHandling] Version 2.16.0 automatic path/URL mapping is backwards…
8a01e72 
… incompatible with existing mapping configuration of wknd.site

* Made mapping optional in `LinkHandler`
* Existing components versions don't use mapping

Closes #1534
@vladbailescu vladbailescu mentioned this issue Apr 26, 2021
Merged
@vladbailescu vladbailescu linked a pull request Apr 26, 2021 that will close this issue
[LinkHandling] Version 2.16.0 automatic path/URL mapping is backwards incompatible with existing mapping configuration of wknd.site #1535
Merged
vladbailescu added a commit that referenced this issue Apr 26, 2021
@vladbailescu
[LinkHandling] Version 2.16.0 automatic path/URL mapping is backwards…
343a32f 
… incompatible with existing mapping configuration of wknd.site

* Moved mapping to a LinkProcessor
* Mapped URL is only used in JSON export

Closes #1534
@vladbailescu vladbailescu linked a pull request Apr 27, 2021 that will close this issue
Expose LinkHandler Model #1536
Closed
@bpauli
Copy link
Contributor

bpauli commented May 7, 2021

fixed in 99af48e

@bpauli bpauli closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected problem or unintended behavior that impairs normal functioning of the product.
Projects
None yet
Milestone
2.16.2
2 participants
@bpauli @vladbailescu