Fixing several issues with the optimized handling of renditions in AdaptiveImageServlet: #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aptiveImageServlet: * Do no try to open non-image renditions as images * Do not try to infer size based on file name, it's not reliable * Use proper asset handler for each rendition (PNG originals might have JPEG renditions)
Codecov Report
@@ Coverage Diff @@
## development #1287 +/- ##
=================================================
- Coverage 84.91% 84.90% -0.02%
- Complexity 1798 1799 +1
=================================================
Files 169 169
Lines 5079 5073 -6
Branches 799 799
=================================================
- Hits 4313 4307 -6
Misses 304 304
Partials 462 462
Continue to review full report at Codecov.
|
kwin
reviewed
Nov 27, 2020
...core/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/EnhancedRendition.java
Outdated
Show resolved
Hide resolved
kwin
reviewed
Nov 27, 2020
...core/src/main/java/com/adobe/cq/wcm/core/components/internal/servlets/EnhancedRendition.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
msagolj
approved these changes
Dec 1, 2020
msagolj
pushed a commit
that referenced
this pull request
Dec 1, 2020
…aptiveImageServlet: (#1287) * Fixing several issues with the optimized handling of renditions in AdaptiveImageServlet: * Do no try to open non-image renditions as images * Do not try to infer size based on file name, it's not reliable * Use proper asset handler for each rendition (PNG originals might have JPEG renditions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279